9:32 a.m.
URL: https://github.com/SSSD/sssd/pull/362
Author: sumit-bose
Title: #362: IPA: format fixes
Action: opened
PR body:
"""
There are format warnings when compiling on 32bit. One is about time_t
where I added SPRItime and the other is about size_t where %zu should be
used.
Related to https://pagure.io/SSSD/sssd/issue/2995
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/362/head:pr362
git checkout pr362
11:31 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
@sumit-bose, patch looks good (and here I'm assuming you built it on 32bits without
any issue).
I'll ACK the patch as soon as I hear back from our internal CI. :-)
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-325720218
1:12 p.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
ACK!
CI: http://vm-058-233.${abc}/logs/job/74/71/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-325748355
1:12 p.m.
New subject: [sssd PR#362][+Accepted] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: +Accepted
2:50 p.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
use "%ld" for time_t
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-325779931
2:50 p.m.
New subject: [sssd PR#362][+Changes requested] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: +Changes requested
2:51 p.m.
New subject: [sssd PR#362][-Accepted] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: -Accepted
2:53 p.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
Use "%ld" for time_t
Or check
57cd3443dcb7c073c5a00a9f2c3c3a3030ae2d3e..aac071824f6c98003f30d49ab440c15b4b53692c
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-325779931
12:29 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
sumit-bose commented:
"""
@lslebodn, for clarification, do you prefer to define SPRItime to 'ld' or use
'%ld' directly in the format template?
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-325885575
3:21 p.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
@lslebodn, for clarification, do you prefer to define SPRItime to
'ld' or use '%ld' directly in the format template?
I do not think we heed constant for `time_t`. IMHO. It simpler to read `"%ld"`
then `"%"SPRItime"`.
And moreover it would not be consistent. (using `"%ld"` in current code and
`"%"SPRItime"` somewhere else.
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326409841
4:03 p.m.
New subject: [sssd PR#362][synchronized] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Author: sumit-bose
Title: #362: IPA: format fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/362/head:pr362
git checkout pr362
4:03 p.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
sumit-bose commented:
"""
ok, new version pushed
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326420097
4:15 p.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
@sumit-bose: You've missed @lslebodn's comment:
https://github.com/SSSD/sssd/pull/362/commits/a4476ff3305c657c929a2915a05...
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326422527
2:59 a.m.
New subject: [sssd PR#362][synchronized] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Author: sumit-bose
Title: #362: IPA: format fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/362/head:pr362
git checkout pr362
3:03 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
sumit-bose commented:
"""
D'oh, new version pushed.
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326517068
3:22 a.m.
New subject: [sssd PR#362][-Changes requested] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: -Changes requested
3:30 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
@sumit-bose: last request (sorry I didn't see this one earlier) ... in the commit
message you say "(...) time_t where I added SPRItime (...)" which is not true
anymore with this new version. Would you mind updating this?
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326522661
4:46 a.m.
New subject: [sssd PR#362][synchronized] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Author: sumit-bose
Title: #362: IPA: format fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/362/head:pr362
git checkout pr362
4:46 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
sumit-bose commented:
"""
Done, new version pushed.
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326538982
5:06 a.m.
New subject: [sssd PR#362][+Accepted] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: +Accepted
5:08 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
fidencio commented:
"""
As the PR now addresses @lslebodn's comments as well, I've added the
"Accepted" label.
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326543420
9:29 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
master:
* 0475a98d313b8380e7fbf98ee0821a65f8140589
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326595450
9:30 a.m.
New subject: [sssd PR#362][comment] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
lslebodn commented:
"""
And sorry for nitpicking. But I prefer simple solution.
And `time_t` is typedef for `long` (via `__kernel_long_t`). If anybody is interested then
in glibc it is in /usr/include/asm-generic/posix_types.h
"""
See the full comment at https://github.com/SSSD/sssd/pull/362#issuecomment-326595878
9:30 a.m.
New subject: [sssd PR#362][closed] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Author: sumit-bose
Title: #362: IPA: format fixes
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/362/head:pr362
git checkout pr362
9:31 a.m.
New subject: [sssd PR#362][+Pushed] IPA: format fixes
URL: https://github.com/SSSD/sssd/pull/362
Title: #362: IPA: format fixes
Label: +Pushed
2428
days inactive
2431
days old
sssd-devel@lists.fedorahosted.org
24 comments
3 participants
participants (3)
-
fidencio -
lslebodn
-
sumit-bose