[PATCH] Move and extend function for finding principal in keytab

[Jan Zelený]

This functionality will be required in tickets #781 and #700.

Jan

[Jan Zelený]

Jan Zelený  wrote:
> This functionality will be required in tickets #781 and #700.
>
> Jan

This is corrected version - removes some compilation-time error messages.

Jan

[Jan Zelený]

Jan Zelený  wrote:
> Jan Zelený  wrote:
> > This functionality will be required in tickets #781 and #700.
> >
> > Jan
>
> This is corrected version - removes some compilation-time error messages.
>
> Jan

self-nack

I just found that this patch and my 008 patch have some bits mixed up, which 
causes them to work together, but the code is at the wrong place.

Jan

[Jan Zelený]

Jan Zelený  wrote:
> Jan Zelený  wrote:
> > This functionality will be required in tickets #781 and #700.
> >
> > Jan
>
> This is corrected version - removes some compilation-time error messages.
>
> Jan

Another correction: the code mixup has been eliminated.

Jan

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/29/2011 03:50 AM, Jan Zelený wrote:
> Jan Zelený  wrote:
> > Jan Zelený  wrote:
> > > This functionality will be required in tickets #781 and #700.
> > >
> > > Jan
> >
> > This is corrected version - removes some compilation-time error messages.
> >
> > Jan
>
> Another correction: the code mixup has been eliminated.

Nack.

In match_principal(), use
krb5_unparse_name_flags(ctx, principal,
                        KRB5_PRINCIPAL_UNPARSE_NO_REALM,
                        &primary);

Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
latter is deprecated. This will also make your comparisons later
somewhat easier, as krb5_principal_get_realm() returns a string instead
of krb5_data.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk2Rx/wACgkQeiVVYja6o6NLeQCePwxUqDODe+aQTGYIKiwUr+hA
> WrsAnix8F6JptpZkjTESp3H49RzuP1Xz
> =KYTJ
> -----END PGP SIGNATURE-----

[Jan Zelený]

Stephen Gallagher  wrote:
> On 03/29/2011 03:50 AM, Jan Zelený wrote:
> > Jan Zelený  wrote:
> > > Jan Zelený  wrote:
> > > > This functionality will be required in tickets #781 and #700.
> > > >
> > > > Jan
> > >
> > > This is corrected version - removes some compilation-time error
> > > messages.
> > >
> > > Jan
> >
> > Another correction: the code mixup has been eliminated.
>
> Nack.
>
> In match_principal(), use
> krb5_unparse_name_flags(ctx, principal,
>                         KRB5_PRINCIPAL_UNPARSE_NO_REALM,
>                         &primary);
>
> Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
> latter is deprecated. This will also make your comparisons later
> somewhat easier, as krb5_principal_get_realm() returns a string instead
> of krb5_data.

Fixed patch in attachment.

Jan

[Jan Zelený]

Jan Zelený  wrote:
> Stephen Gallagher  wrote:
> > On 03/29/2011 03:50 AM, Jan Zelený wrote:
> > > Jan Zelený  wrote:
> > > > Jan Zelený  wrote:
> > > > > This functionality will be required in tickets #781 and #700.
> > > > >
> > > > > Jan
> > > >
> > > > This is corrected version - removes some compilation-time error
> > > > messages.
> > > >
> > > > Jan
> > >
> > > Another correction: the code mixup has been eliminated.
> >
> > Nack.
> >
> > In match_principal(), use
> > krb5_unparse_name_flags(ctx, principal,
> >                     KRB5_PRINCIPAL_UNPARSE_NO_REALM,
> >                     &primary);
> >
> > Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
> > latter is deprecated. This will also make your comparisons later
> > somewhat easier, as krb5_principal_get_realm() returns a string instead
> > of krb5_data.
>
> Fixed patch in attachment.
>
> Jan

Just a reminder that the updated patch needs review.

Thanks
Jan

[Stephen Gallagher]

On Tue, 2011-03-29 at 15:20 +0200, Jan Zelený wrote:
> Stephen Gallagher  wrote:
> > Nack.
> >
> > In match_principal(), use
> > krb5_unparse_name_flags(ctx, principal,
> >                         KRB5_PRINCIPAL_UNPARSE_NO_REALM,
> >                         &primary);
> >
> > Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
> > latter is deprecated. This will also make your comparisons later
> > somewhat easier, as krb5_principal_get_realm() returns a string instead
> > of krb5_data.
>
> Fixed patch in attachment.

Ack

[Stephen Gallagher]

On Wed, 2011-04-20 at 10:25 -0400, Stephen Gallagher wrote:
> On Tue, 2011-03-29 at 15:20 +0200, Jan Zelený wrote:
> > Stephen Gallagher  wrote:
> > > Nack.
> > >
> > > In match_principal(), use
> > > krb5_unparse_name_flags(ctx, principal,
> > >                         KRB5_PRINCIPAL_UNPARSE_NO_REALM,
> > >                         &primary);
> > >
> > > Please use krb5_principal_get_realm() instead of krb5_princ_realm(). The
> > > latter is deprecated. This will also make your comparisons later
> > > somewhat easier, as krb5_principal_get_realm() returns a string instead
> > > of krb5_data.
> >
> > Fixed patch in attachment.
>
> Ack

Pushed to master.