[sssd PR#288][opened] Fix several pep8 issues in the integration tests.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/288
Author: jhrozek
 Title: #288: Fix several pep8 issues in the integration tests.
Action: opened

PR body:
"""
Mostly these are my fault, I think they were introduced while accomodating
review comments..

CI: http://sssd-ci.duckdns.org/logs/job/70/32/summary.html
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/288/head:pr288
git checkout pr288

[sssd PR#288][comment] Fix several pep8 issues in the integration tests.

[fidencio]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

fidencio commented:
"""
Patches look good.
ACK from me.

@jhrozek, @lslebodn: isn't there an automatically way to always run pep8 during our tests and fail when we introduce any error?
"""

See the full comment at https://github.com/SSSD/sssd/pull/288#issuecomment-304605355

[sssd PR#288][+Accepted] Fix several pep8 issues in the integration tests.

[fidencio]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

Label: +Accepted

[sssd PR#288][comment] Fix several pep8 issues in the integration tests.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

jhrozek commented:
"""
On Mon, May 29, 2017 at 01:33:56AM -0700, fidencio wrote:
> Patches look good.
> ACK from me.
>
> @jhrozek, @lslebodn: isn't there an automatically way to always run pep8 during our tests and fail when we introduce any error?

Dunno, but I think a pep8 test during CI would be handy in the same way
as we have a whitespace test already.

"""

See the full comment at https://github.com/SSSD/sssd/pull/288#issuecomment-304607931

[sssd PR#288][+Changes requested] Fix several pep8 issues in the integration tests.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

Label: +Changes requested

[sssd PR#288][-Accepted] Fix several pep8 issues in the integration tests.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

Label: -Accepted

[sssd PR#288][comment] Fix several pep8 issues in the integration tests.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

lslebodn commented:
"""
> @jhrozek, @lslebodn: isn't there an automatically way to always run pep8 during our tests and fail when we introduce any error?

@fidencio it is an open source project and patches are welcome :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/288#issuecomment-304624969

[sssd PR#288][synchronized] Fix several pep8 issues in the integration tests.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/288
Author: jhrozek
 Title: #288: Fix several pep8 issues in the integration tests.
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/288/head:pr288
git checkout pr288

[sssd PR#288][comment] Fix several pep8 issues in the integration tests.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

jhrozek commented:
"""
On Mon, May 29, 2017 at 03:06:17AM -0700, lslebodn wrote:
> lslebodn commented on this pull request.
> >  cc_coll = testenv.k5util.list_all_princs()
>  assert len(cc_coll) == 2
>  assert cc_coll['alice@KCMTEST'] == ['krbtgt/KCMTEST@KCMTEST']
>  assert cc_coll['bob@KCMTEST'] == ['krbtgt/KCMTEST@KCMTEST']
>  assert 'carol@KCMTEST' not in cc_coll
>
>  # FIXME - a bug in libkrb5?
> #out = testenv.k5util.kdestroy(all_ccaches=True)
> #assert out == 0
> #cc_coll = testenv.k5util.list_all_princs()
> #assert len(cc_coll) == 0
> # out = testenv.k5util.kdestroy(all_ccaches=True)
> # assert out == 0
> # cc_coll = testenv.k5util.list_all_princs()
> # assert len(cc_coll) == 0
>
> I would prefer to remove this code

OK, but in order to not forget about this case, I filed
https://pagure.io/SSSD/sssd/issue/3413

"""

See the full comment at https://github.com/SSSD/sssd/pull/288#issuecomment-304632389

[sssd PR#288][-Changes requested] Fix several pep8 issues in the integration tests.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

Label: -Changes requested

[sssd PR#288][comment] Fix several pep8 issues in the integration tests.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

lslebodn commented:
"""
master:
* 84ae0c4345baf1a589a237bfd132acdaf7a56738
* af435c498eccdb39539350cd0e65371da7949b01
* 5d9df623e1999864fd2873d8784a5182558f4a1f
* 89726be5a05493b7af312f0be9ac5ecb6f1822e1
"""

See the full comment at https://github.com/SSSD/sssd/pull/288#issuecomment-304636414

[sssd PR#288][+Pushed] Fix several pep8 issues in the integration tests.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/288
Title: #288: Fix several pep8 issues in the integration tests.

Label: +Pushed

[sssd PR#288][closed] Fix several pep8 issues in the integration tests.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/288
Author: jhrozek
 Title: #288: Fix several pep8 issues in the integration tests.
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/288/head:pr288
git checkout pr288