URL: https://github.com/SSSD/sssd/pull/860 Author: scabrero Title: #860: Prepare for multiple enumeration providers Action: opened
PR body: """ This prepares the road for future enumeration-capable providers. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/860/head:pr860 git checkout pr860
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-518757431
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
pbrezina commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-527349996
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
pbrezina commented: """ I will read through the code during next week. I'm sorry it takes so long. In the mean time, can `make check` fails. Can you fix it please? [See logs](https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-860/6/fedora-rawhide/ci-mak...). """
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-530798392
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/860 Author: scabrero Title: #860: Prepare for multiple enumeration providers Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/860/head:pr860 git checkout pr860
URL: https://github.com/SSSD/sssd/pull/860 Author: scabrero Title: #860: Prepare for multiple enumeration providers Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/860/head:pr860 git checkout pr860
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
scabrero commented: """ Thanks for review @pbrezina, I did the requested changes. The final goal is to add NSS hosts and networks support for sssd (https://github.com/scabrero/sssd/tree/nss-host-support). The hosts support is finished, but the new integration test fails unless you add sss to nsswitch.conf because nss_wrapper does not follow NSS_WRAPPER_MODULE_FN_PREFIX for hosts lookup. I am working on a patch for nss_wrapper. """
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-532667787
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
pbrezina commented: """ Thank you for your explanation. Please, fix the nitpick and I will ack it then. """
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-539485665
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/860 Author: scabrero Title: #860: Prepare for multiple enumeration providers Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/860/head:pr860 git checkout pr860
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
pbrezina commented: """ Ack. Thank you. """
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-541011207
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
pbrezina commented: """ * `master` * 66873cac4963675a700d3529d24f6da668f9c16e - LDAP: Move enum fields to id provider context * d91c1f4aee4761af7df71b882bf9fb4841802133 - LDAP: Remove unnecessary task pointer * 7375083a8620b4b56120e0379b4996d7743ad7a6 - LDAP: Improve ldap_id_setup_enumeration error logic * 2995a895d71d523ae67f399b622ba47fba3bfa8f - AD: Rename enumeration functions to contain the provider name * acca871d7d3e7f0f6c84dab600dda259dfe1c624 - LDAP: Rename enumeration and cleanup functions to contain the provider * 4555b81795d6ef23d139245ba23ca97d8e1cd67e - LDAP: Return errno_t for ldap id enumeration task setup functions * f6ada94aea3835069b93e7c1b73dd3f91a4a15f4 - SDAP: Add provider name to enumeration and cleanup tasks * 4981fe3410a56562272a7b3235352d1aae06e94b - SYSDB: Convert cached domain 'enumerated' attribute from bool to uint
"""
See the full comment at https://github.com/SSSD/sssd/pull/860#issuecomment-542120399
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/860 Title: #860: Prepare for multiple enumeration providers
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/860 Author: scabrero Title: #860: Prepare for multiple enumeration providers Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/860/head:pr860 git checkout pr860
sssd-devel@lists.fedorahosted.org
-
centos-ci -
pbrezina
-
scabrero