[sssd PR#832][opened] SPECFILE: Add 'make' as build dependency

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/832
Author: mzidek-rh
 Title: #832: SPECFILE: Add 'make' as build dependency
Action: opened

PR body:
"""
This caused some of my scripts fail when building SSSD
after fetching build dependencies from srpm because
make was not installed.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/832/head:pr832
git checkout pr832

[sssd PR#832][comment] SPECFILE: Add 'make' as build dependency

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

jhrozek commented:
"""
On one hand this patch is harmless, on the other hand I don't think it's needed. mock or similar would bootstrap the environment for you and if you're rebuilding the package with rpmbuild directly, you need to install other dependencies yourself anyway..

I mean, we don't buildRequire patch or sed either..

So I'm inclined to close this PR, but I won't do it now in case someone disagrees with me.
"""

See the full comment at https://github.com/SSSD/sssd/pull/832#issuecomment-505157812

[sssd PR#832][comment] SPECFILE: Add 'make' as build dependency

[mzidek-rh]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

mzidek-rh commented:
"""
The backstory for this patch is that I was installing minimal VM where I wanted to build SSSD from sources and after installing the dependencies using "sudo dnf builddep rpmbuild/SRPMS/sssd-*.src.rpm" the "make" was still not there, so I had to install it manually in additional step.
"""

See the full comment at https://github.com/SSSD/sssd/pull/832#issuecomment-505344986

[sssd PR#832][comment] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

pbrezina commented:
"""
Well, we can perhaps put all missing dependencies there (I mean even patch and sed and perhaps other) to have the complete list. It may be helpful because e.g. fedora-cloud vagrant boxes does not have development packages installed (as Michal found out).
"""

See the full comment at https://github.com/SSSD/sssd/pull/832#issuecomment-522977527

[sssd PR#832][comment] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

pbrezina commented:
"""
I'm going to ack this patch, it is harmless and a valid dependency that is sometimes useful. Please, stand up if someone disagrees.

Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/832#issuecomment-532571882

[sssd PR#832][+Accepted] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

Label: +Accepted

[sssd PR#832][+Ready to push] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

Label: +Ready to push

[sssd PR#832][comment] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

pbrezina commented:
"""
* `master`
    * cb04b141895b422b0d16685646a18093ba3498a8 - SPECFILE: Add 'make' as build dependency

"""

See the full comment at https://github.com/SSSD/sssd/pull/832#issuecomment-533459373

[sssd PR#832][+Pushed] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

Label: +Pushed

[sssd PR#832][-Accepted] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Title: #832: SPECFILE: Add 'make' as build dependency

Label: -Accepted

[sssd PR#832][closed] SPECFILE: Add 'make' as build dependency

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/832
Author: mzidek-rh
 Title: #832: SPECFILE: Add 'make' as build dependency
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/832/head:pr832
git checkout pr832