URL: https://github.com/SSSD/sssd/pull/5758 Author: alexey-tikhonov Title: #5758: file utils: reduce log level in remove_tree_with_ctx() Action: opened
PR body: """ Users of this function are responsible to decide if fail is critical. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5758/head:pr5758 git checkout pr5758
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: +Bugzilla
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
alexey-tikhonov commented: """ RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1995608 """
See the full comment at https://github.com/SSSD/sssd/pull/5758#issuecomment-903777867
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
alexey-tikhonov commented: """ @elkoniu, do you have other comments? """
See the full comment at https://github.com/SSSD/sssd/pull/5758#issuecomment-904910413
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
elkoniu commented: """
@elkoniu, do you have other comments?
Code LGTM so I set Accepted flag. The only question I would have is that `remove_tree_with_ctx()` result is not evaluated in `sss_remove_tree()` and `sss_remove_subtree()` functions. But it was not evaluated in the past too so change is not needed. """
See the full comment at https://github.com/SSSD/sssd/pull/5758#issuecomment-905015343
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5758
* `master` * bd2ccbf69af8e5836f6f6e09a893d54428d903c5 - file utils: reduce log level in remove_tree_with_ctx() Users of this function are responsible to decide if fail is critical.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5758#issuecomment-905345922
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5758 Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5758 Author: alexey-tikhonov Title: #5758: file utils: reduce log level in remove_tree_with_ctx() Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5758/head:pr5758 git checkout pr5758
sssd-devel@lists.fedorahosted.org