We have used the error status from c-ares to decide whether to mark the request as failed or not. This is wrong, but mostly worked fine because we have been getting some error code from c-ares in all situations until we added the per-request timeouts. We should use the errno code and only use the c-ares return code to print extended debugging information.
On Tue, 2012-03-27 at 18:23 -0400, Jakub Hrozek wrote:
We have used the error status from c-ares to decide whether to mark the request as failed or not. This is wrong, but mostly worked fine because we have been getting some error code from c-ares in all situations until we added the per-request timeouts. We should use the errno code and only use the c-ares return code to print extended debugging information.
Ack for master and sssd-1-8
On Thu, 2012-03-29 at 14:47 -0400, Stephen Gallagher wrote:
On Tue, 2012-03-27 at 18:23 -0400, Jakub Hrozek wrote:
We have used the error status from c-ares to decide whether to mark the request as failed or not. This is wrong, but mostly worked fine because we have been getting some error code from c-ares in all situations until we added the per-request timeouts. We should use the errno code and only use the c-ares return code to print extended debugging information.
Ack for master and sssd-1-8
These were pushed to master and sssd-1-8 last week. I forgot to send the email.
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Stephen Gallagher