[PATCH] MAN: Clarify that subdomains always use service discovery

[Jakub Hrozek]

Hi.

attached is a simple manpage patch for #2881.

[Jakub Hrozek]

On Thu, Nov 26, 2015 at 05:10:57PM +0100, Jakub Hrozek wrote:
> Hi.
>
> attached is a simple manpage patch for #2881.

Sorry, here's the correct one.

[Pavel Březina]

On 11/26/2015 05:10 PM, Jakub Hrozek wrote:
> Hi.
>
> attached is a simple manpage patch for #2881.

Ack.

[Dan Lavu]

Lukas,

Fixed some grammatical errors and wording. Also noticed the line about supported AD versions, please correct me if I'm wrong, but we only officially support 2008R2 and 2012R2 so I modified that line stating that.

Dan

----- Original Message -----

From: "Pavel Březina"  
To: [e-mail] 
Sent: Monday, November 30, 2015 4:36:10 AM 
Subject: [SSSD]Re: [PATCH] MAN: Clarify that subdomains always use service discovery

On 11/26/2015 05:10 PM, Jakub Hrozek wrote:
> Hi.
>
> attached is a simple manpage patch for #2881.

Ack. 
_______________________________________________ 
sssd-devel mailing list 
[e-mail] 
https://lists.fedorahosted.org/admin/lists/[e-mail]

[Jakub Hrozek]

On Mon, Nov 30, 2015 at 05:01:53AM -0500, Dan Lavu wrote:
> Lukas,
>
> Fixed some grammatical errors and wording. Also noticed the line about supported AD versions, please correct me if I'm wrong, but we only officially support 2008R2 and 2012R2 so I modified that line stating that.
>
> Dan
>
> ----- Original Message -----
>
> From: "Pavel Březina"  
> To: [e-mail] 
> Sent: Monday, November 30, 2015 4:36:10 AM 
> Subject: [SSSD]Re: [PATCH] MAN: Clarify that subdomains always use service discovery
>
> On 11/26/2015 05:10 PM, Jakub Hrozek wrote:
> > Hi.
> >
> > attached is a simple manpage patch for #2881.
>
> Ack. 
> _______________________________________________ 
> sssd-devel mailing list 
> [e-mail] 
> https://lists.fedorahosted.org/admin/lists/[e-mail]

Hi,
> From 3cb1cd429c59e380a264d13d4299f76e10238799 Mon Sep 17 00:00:00 2001
> From: Dan Lavu 
> Date: Mon, 30 Nov 2015 04:51:00 -0500
> Subject: [PATCH] Clarify that subdomains always use service discovery
>
> src/man/sssd-ad.5.xml | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml
> index 047cf046d425ed32a4983691c18dc9f8b94a0160..d3f360e7db5358d159954cdddeaf3ff38a79ce3e 100644
> --- a/src/man/sssd-ad.5.xml
> +++ b/src/man/sssd-ad.5.xml
> @@ -39,12 +39,13 @@
>          </para>
>          <para>
>              The AD provider supports connecting to Active Directory 2008 R2
>        or later. Earlier versions may work, but are unsupported.
>        and 2012 R2. Other versions may work, but are unsupported.

I don't think we want to do this change. I know you're coming from your
downstream perspective where I would agree, but in upstream, we should
support also 2016 when it comes out and 2012.0 (as opposed to R2).
>      </para>
>      <para>
>        The AD provider is able to provide identity information and
>        authentication for entities from trusted domains as well. Currently
>        only trusted domains in the same forest are recognized.
>        The AD provider can be used to get user information
>        and authenticate users from trusted domains. Currently
>        only trusted domains in the same forest are recognized. In
>        addition servers from trusted domains are always auto-discovered.
>    </para>
>    <para>
>        The AD provider accepts the same options used by the
>
> @@ -121,10 +122,17 @@ ldap_id_mapping = False
>                              connect in order of preference. For more
>                              information on failover and server redundancy, see
>                              the <quote>FAILOVER</quote> section.
>                    </para>
>                    <para>
>                        This is optional if autodiscovery is enabled.
>                        For more information on service discovery, refer
>                        to the <quote>SERVICE DISCOVERY</quote> section.
>                    </para>
>                    <para>
>                        Note: Trusted domains will always auto-discover
>                        servers even if the primary server is explicitly
>                        defined in the ad_server option.
>                    </para>
>                </listitem>
>            </varlistentry>

I agree with the rest of the changes and if you agree with dropping the
first hunk, I'll push the patch.

[Jakub Hrozek]

On Mon, Nov 30, 2015 at 05:41:35PM +0100, Jakub Hrozek wrote:
> On Mon, Nov 30, 2015 at 05:01:53AM -0500, Dan Lavu wrote:
> > Lukas,
> >
> > Fixed some grammatical errors and wording. Also noticed the line about supported AD versions, please correct me if I'm wrong, but we only officially support 2008R2 and 2012R2 so I modified that line stating that.
> >
> > Dan
> >
> > ----- Original Message -----
> >
> > From: "Pavel Březina"  
> > To: [e-mail] 
> > Sent: Monday, November 30, 2015 4:36:10 AM 
> > Subject: [SSSD]Re: [PATCH] MAN: Clarify that subdomains always use service discovery
> >
> > On 11/26/2015 05:10 PM, Jakub Hrozek wrote:
> > > Hi.
> > >
> > > attached is a simple manpage patch for #2881.
> >
> > Ack. 
> > _______________________________________________ 
> > sssd-devel mailing list 
> > [e-mail] 
> > https://lists.fedorahosted.org/admin/lists/[e-mail]
>
> Hi,
> > From 3cb1cd429c59e380a264d13d4299f76e10238799 Mon Sep 17 00:00:00 2001
> > From: Dan Lavu 
> > Date: Mon, 30 Nov 2015 04:51:00 -0500
> > Subject: [PATCH] Clarify that subdomains always use service discovery
> >
> > src/man/sssd-ad.5.xml | 16 ++++++++++++----
> >  1 file changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/man/sssd-ad.5.xml b/src/man/sssd-ad.5.xml
> > index 047cf046d425ed32a4983691c18dc9f8b94a0160..d3f360e7db5358d159954cdddeaf3ff38a79ce3e 100644
> > --- a/src/man/sssd-ad.5.xml
> > +++ b/src/man/sssd-ad.5.xml
> > @@ -39,12 +39,13 @@
> >          </para>
> >          <para>
> >              The AD provider supports connecting to Active Directory 2008 R2
> >        or later. Earlier versions may work, but are unsupported.
> >        and 2012 R2. Other versions may work, but are unsupported.
>
> I don't think we want to do this change. I know you're coming from your
> downstream perspective where I would agree, but in upstream, we should
> support also 2016 when it comes out and 2012.0 (as opposed to R2).
> >      </para>
> >      <para>
> >        The AD provider is able to provide identity information and
> >        authentication for entities from trusted domains as well. Currently
> >        only trusted domains in the same forest are recognized.
> >        The AD provider can be used to get user information
> >        and authenticate users from trusted domains. Currently
> >        only trusted domains in the same forest are recognized. In
> >        addition servers from trusted domains are always auto-discovered.
> >    </para>
> >    <para>
> >        The AD provider accepts the same options used by the
> >
> > @@ -121,10 +122,17 @@ ldap_id_mapping = False
> >                              connect in order of preference. For more
> >                              information on failover and server redundancy, see
> >                              the <quote>FAILOVER</quote> section.
> >                    </para>
> >                    <para>
> >                        This is optional if autodiscovery is enabled.
> >                        For more information on service discovery, refer
> >                        to the <quote>SERVICE DISCOVERY</quote> section.
> >                    </para>
> >                    <para>
> >                        Note: Trusted domains will always auto-discover
> >                        servers even if the primary server is explicitly
> >                        defined in the ad_server option.
> >                    </para>
> >                </listitem>
> >            </varlistentry>
>
> I agree with the rest of the changes and if you agree with dropping the
> first hunk, I'll push the patch.

Hi Dan,

are you OK with droppig the first paragraph about Windows server
supported versions?