[sssd PR#135][opened] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Author: lslebodn
 Title: #135: BUILD: Fix linking of test_wbc_calls
Action: opened

PR body:
"""
Client code does not anymore depend on libpthread in master.
This is a reason why we didn't notice any linking failure
 in master. But the test should be inked with CLIENT_LIBS.

```    
     CCLD     test_wbc_calls
    /usr/bin/ld: src/sss_client/test_wbc_calls-common.o: undefined reference
        to symbol 'pthread_mutexattr_setrobust@@GLIBC_2.12'
    //lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing
        from command line
    collect2: error: ld returned 1 exit status
    Makefile:12460: recipe for target 'test_wbc_calls' failed
```
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/135/head:pr135
git checkout pr135

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

lslebodn commented:
"""
http://sssd-ci.duckdns.org/logs/job/61/40/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275163260

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

fidencio commented:
"""
@lslebodn:

Although the fix seems quite simple I have to admit I didn't understand it.
CLIENT_LIBS is LTLIBINTL, right? How does it pull the missing symbol?
"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275168032

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

lslebodn commented:
"""
> Although the fix seems quite simple I have to admit I didn't understand it.
> CLIENT_LIBS is LTLIBINTL, right? How does it pull the missing symbol?

Did you check Makefile from master or sssd-1-14 branch?
I can see additional dependencies in 1.14. And AS you can see this patch is for 1.14

"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275347688

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

fidencio commented:
"""
Oh yeah, my bad. On 1.14 the Makefile also contains:

```
if HAVE_PTHREAD
CLIENT_LIBS += -lpthread
endif
```

Just a small nitpick in the commit message:
- ΅inked" -> "linked"
"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275349768

[sssd PR#135][+Accepted] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

Label: +Accepted

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

lslebodn commented:
"""
On (26/01/17 01:58), fidencio wrote:
> Oh yeah, my bad. On 1.14 the Makefile also contains:
> if HAVE_PTHREAD
> CLIENT_LIBS += -lpthread
> endif
>
> Just a small nitpick in the commit message:
> ΅inked" -> "linked"

Fixed
Thank you.

I realized it make sense to have it also in master
due to LTLIBINTL

master:
* c369b062182c746849196e495db467198039edf4

sssd-1-14:
* 9e2190b898558ee51745da7e8aeef9ca6b049986

sssd-1-13:
* 2c4cc58974b72de875bf851713474180c403c6c6

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275385936

[sssd PR#135][closed] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Author: lslebodn
 Title: #135: BUILD: Fix linking of test_wbc_calls
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/135/head:pr135
git checkout pr135

[sssd PR#135][+Pushed] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

Label: +Pushed

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

fidencio commented:
"""
On Thu, Jan 26, 2017 at 2:18 PM, lslebodn  wrote:
> On (26/01/17 01:58), fidencio wrote:
> > Oh yeah, my bad. On 1.14 the Makefile also contains:
> > if HAVE_PTHREAD
> > CLIENT_LIBS += -lpthread
> > endif
> >
> > Just a small nitpick in the commit message:
> > ΅inked" -> "linked"
>
> Fixed
> Thank you.
>
> I realized it make sense to have it also in master
> due to LTLIBINTL
>
> master:
> c369b062182c746849196e495db467198039edf4

Although the patch makes sense for master, the commit message doesn't :-\
That's okay it's already pushed but for future cases would be better to
double-check before pushing.
> sssd-1-14:
> 9e2190b898558ee51745da7e8aeef9ca6b049986
>
> sssd-1-13:
> 2c4cc58974b72de875bf851713474180c403c6c6
>
> LS
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> https://github.com/SSSD/sssd/pull/135#issuecomment-275385936, or mute
> the thread
> https://github.com/notifications/unsubscribe-auth/AAG4eo4VUd7iJq0oX4wwIkaiiY_mvvj2ks5rWJ0LgaJpZM4Ltm1O
> .

"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275389246

[sssd PR#135][comment] BUILD: Fix linking of test_wbc_calls

[fidencio]

URL: https://github.com/SSSD/sssd/pull/135
Title: #135: BUILD: Fix linking of test_wbc_calls

lslebodn commented:
"""
Just linking error does not fit. But it was simpler to backport it without changing commit message.
"""

See the full comment at https://github.com/SSSD/sssd/pull/135#issuecomment-275390398