9:47 a.m.
Hello,
I have been working on this ticket[1] to allow selection of file paths
for alternate passwd and group files to be used with the files provider.
First, just to make sure I am not completely on the wrong track I would
like to ask for someone to take a quick look at the current
work-in-progress code I have here in my SSSD fork to validate that it
matches up with the expected implementation.
https://github.com/SSSD/sssd/compare/master...justin-stephenson:jstephen-...
Second, assuming I am not completely off track I would appreciate any
help on a code problem I am having here when sf_init() gets called to
setup watches on the passwd_files and group_files lists, the list values
are corrupted or inaccessible. I started off with the code from the
function files_init_alt_files() inside sssm_files_init() directly and
everything works as expected, the problem started when I moved the code
into this separate function.
The list values are retrieved from the new alt_passwd_files and
alt_group_files options or default to /etc/passwd and /etc/group files.
Inside sssm_files_init() I am able to access the correct values of each
string element in the list but when sf_init() is called the list is
corrupt or I am performing some undefined behavior that I cannot determine.
The debug log look something like this in my testing when three
different files are provided to the new conf options.
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sssm_files_init] (0x0400):
Found passwd file: [/etc/passwd].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sssm_files_init] (0x0400):
Found passwd file: [/opt/testpasswd].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sssm_files_init] (0x0400):
Found passwd file: [/usr/passwd].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sssm_files_init] (0x0400):
Found group file: [/etc/group].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sssm_files_init] (0x0400):
Found group file: [/opt/testgroup].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sssm_files_init] (0x0400):
Found group file: [/usr/group].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sf_init] (0x0400): Setting
up passwd watch on [/etc/passwd].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened inotify fd 17
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened file watch 1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened directory watch 2
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [_snotify_create] (0x0400):
Added a watch for /etc/passwd with inotify flags 0xD88 internal flags
0x1 using function fn after delay 0.0
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sf_init] (0x0400): Setting
up passwd watch on [`<DE><F6>^]hU].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened inotify fd 18
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened file watch -1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened directory watch 1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [_snotify_create] (0x0400):
Added a watch for `<DE><F6>^]hU with inotify flags 0xD88 internal flags
0x1 using function fn after delay 0.0
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sf_init] (0x0400): Setting
up passwd watch on [/etc/passwd].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened inotify fd 19
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened file watch 1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened directory watch 2
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [_snotify_create] (0x0400):
Added a watch for /etc/passwd with inotify flags 0xD88 internal flags
0x1 using function fn after delay 0.0
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sf_init] (0x0400): Setting
up group watch on [/etc/group].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened inotify fd 20
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened file watch 1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened directory watch 2
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [_snotify_create] (0x0400):
Added a watch for /etc/group with inotify flags 0xD88 internal flags 0x1
using function fn after delay 0.0
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sf_init] (0x0400): Setting
up group watch on [^Q].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened inotify fd 21
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened file watch -1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened directory watch 1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [_snotify_create] (0x0400):
Added a watch for ^Q with inotify flags 0xD88 internal flags 0x1 using
function fn after delay 0.0
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [sf_init] (0x0400): Setting
up group watch on [/usr/group].
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened inotify fd 22
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened file watch 1
(Wed Dec 20 10:02:48 2017) [sssd[be[files]]] [snotify_watch] (0x2000):
Opened directory watch 2
Lastly, if there are other considerations I have missed here regarding
files provider logic please let me know and i'll work on it.
Any input is much appreciated, thank you.
[1] https://pagure.io/SSSD/sssd/issue/3402
Kind regards,
Justin Stephenson
10:48 a.m.
New subject: Requesting help with files provider ticket 3402 implementation
On Wed, Dec 20, 2017 at 10:47:38AM -0500, Justin Stephenson wrote:
Hello,
I have been working on this ticket[1] to allow selection of file paths for
alternate passwd and group files to be used with the files provider.
First, just to make sure I am not completely on the wrong track I would like
to ask for someone to take a quick look at the current work-in-progress code
I have here in my SSSD fork to validate that it matches up with the expected
implementation.
https://github.com/SSSD/sssd/compare/master...justin-stephenson:jstephen-...
Second, assuming I am not completely off track I would appreciate any help
on a code problem I am having here when sf_init() gets called to setup
watches on the passwd_files and group_files lists, the list values are
corrupted or inaccessible. I started off with the code from the function
files_init_alt_files() inside sssm_files_init() directly and everything
works as expected, the problem started when I moved the code into this
separate function.
The list values are retrieved from the new alt_passwd_files and
alt_group_files options or default to /etc/passwd and /etc/group files.
Inside sssm_files_init() I am able to access the correct values of each
string element in the list but when sf_init() is called the list is corrupt
or I am performing some undefined behavior that I cannot determine.
Hi Justin,
I'm sorry I forgot about this issue even though you pinged me about it
via an e-mail.
I think the following diff might help:
diff --git a/src/providers/files/files_init.c b/src/providers/files/files_init.c
index e0064bc4b..7fd0ff0ca 100644
--- a/src/providers/files/files_init.c
+++ b/src/providers/files/files_init.c
@@ -77,7 +77,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
goto done;
}
- passwd_files[0] = talloc_strdup(tmp_ctx, DEFAULT_PASSWD_FILE);
+ passwd_files[0] = talloc_strdup(passwd_files, DEFAULT_PASSWD_FILE);
if (passwd_files[0] == NULL) {
ret = ENOMEM;
goto done;
@@ -101,7 +101,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
}
for (i = 0; i < num_passwd_files; i++) {
- passwd_files[i] = talloc_strdup(tmp_ctx, passwd_list[i]);
+ passwd_files[i] = talloc_strdup(passwd_files, passwd_list[i]);
if (passwd_files[i] == NULL) {
ret = ENOMEM;
goto done;
@@ -120,7 +120,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
goto done;
}
- group_files[0] = talloc_strdup(tmp_ctx, DEFAULT_GROUP_FILE);
+ group_files[0] = talloc_strdup(group_files, DEFAULT_GROUP_FILE);
if (group_files[0] == NULL) {
ret = ENOMEM;
goto done;
@@ -144,7 +144,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
}
for (i = 0; i < num_group_files; i++) {
- group_files[i] = talloc_strdup(tmp_ctx, group_list[i]);
+ group_files[i] = talloc_strdup(group_files, group_list[i]);
if (group_files[i] == NULL) {
ret = ENOMEM;
goto done;
Without the diff, the memory hierarchy looks like this:
tmp_ctx +
+ group_files
+ altfile1
+ altfile2
+ ...
So at the end of the function, when you steal group_files, you only steal
the array "envelope", but not the contents. With the fix, the hierarchy
looks like this:
tmp_ctx +
+ group_files +
+ altfile1
+ altfile2
+ ...
So when you steal group_files, you also steal what group_files owns.
11:55 a.m.
New subject: Requesting help with files provider ticket 3402 implementation
On 12/20/2017 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 20, 2017 at 10:47:38AM -0500, Justin Stephenson wrote:
> Hello,
>
> I have been working on this ticket[1] to allow selection of file paths for
> alternate passwd and group files to be used with the files provider.
>
> First, just to make sure I am not completely on the wrong track I would like
> to ask for someone to take a quick look at the current work-in-progress code
> I have here in my SSSD fork to validate that it matches up with the expected
> implementation.
>
>
https://github.com/SSSD/sssd/compare/master...justin-stephenson:jstephen-...
>
> Second, assuming I am not completely off track I would appreciate any help
> on a code problem I am having here when sf_init() gets called to setup
> watches on the passwd_files and group_files lists, the list values are
> corrupted or inaccessible. I started off with the code from the function
> files_init_alt_files() inside sssm_files_init() directly and everything
> works as expected, the problem started when I moved the code into this
> separate function.
>
> The list values are retrieved from the new alt_passwd_files and
> alt_group_files options or default to /etc/passwd and /etc/group files.
> Inside sssm_files_init() I am able to access the correct values of each
> string element in the list but when sf_init() is called the list is corrupt
> or I am performing some undefined behavior that I cannot determine.
Hi Justin,
I'm sorry I forgot about this issue even though you pinged me about it
via an e-mail.
I think the following diff might help:
diff --git a/src/providers/files/files_init.c b/src/providers/files/files_init.c
index e0064bc4b..7fd0ff0ca 100644
--- a/src/providers/files/files_init.c
+++ b/src/providers/files/files_init.c
@@ -77,7 +77,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
goto done;
}
- passwd_files[0] = talloc_strdup(tmp_ctx, DEFAULT_PASSWD_FILE);
+ passwd_files[0] = talloc_strdup(passwd_files, DEFAULT_PASSWD_FILE);
if (passwd_files[0] == NULL) {
ret = ENOMEM;
goto done;
@@ -101,7 +101,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
}
for (i = 0; i < num_passwd_files; i++) {
- passwd_files[i] = talloc_strdup(tmp_ctx, passwd_list[i]);
+ passwd_files[i] = talloc_strdup(passwd_files, passwd_list[i]);
if (passwd_files[i] == NULL) {
ret = ENOMEM;
goto done;
@@ -120,7 +120,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
goto done;
}
- group_files[0] = talloc_strdup(tmp_ctx, DEFAULT_GROUP_FILE);
+ group_files[0] = talloc_strdup(group_files, DEFAULT_GROUP_FILE);
if (group_files[0] == NULL) {
ret = ENOMEM;
goto done;
@@ -144,7 +144,7 @@ static errno_t files_init_alt_files(TALLOC_CTX *mem_ctx,
}
for (i = 0; i < num_group_files; i++) {
- group_files[i] = talloc_strdup(tmp_ctx, group_list[i]);
+ group_files[i] = talloc_strdup(group_files, group_list[i]);
if (group_files[i] == NULL) {
ret = ENOMEM;
goto done;
Without the diff, the memory hierarchy looks like this:
tmp_ctx +
+ group_files
+ altfile1
+ altfile2
+ ...
So at the end of the function, when you steal group_files, you only steal
the array "envelope", but not the contents. With the fix, the hierarchy
looks like this:
tmp_ctx +
+ group_files +
+ altfile1
+ altfile2
+ ...
So when you steal group_files, you also steal what group_files owns.
Makes sense, and that fixed it. Thanks!
Kind regards,
Justin Stephenson
> _______________________________________________
> sssd-devel mailing list -- sssd-devel(a)lists.fedorahosted.org
> To unsubscribe send an email to sssd-devel-leave(a)lists.fedorahosted.org
>
2329
days inactive
2329
days old
sssd-devel@lists.fedorahosted.org
2 comments
2 participants
participants (2)
-
Jakub Hrozek -
Justin Stephenson