This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
Looks like tests failed: http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
Looks like tests failed: http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
I forgot to run tests... new patches are attached.
On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
Looks like tests failed: http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
I forgot to run tests... new patches are attached.
Thanks, the patches now build. I have two questions: 1) Since we're moving code around anymore, would it make sense to also move the enums with option indexes to opts.h? I find it a bit odd they are in common.h 2) Does it make sense to remove the remaining headers (data_provider and common) from opts.h and leave only options in?
On 12/04/2015 03:51 PM, Jakub Hrozek wrote:
On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
Looks like tests failed: http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
I forgot to run tests... new patches are attached.
Thanks, the patches now build. I have two questions: 1) Since we're moving code around anymore, would it make sense to also move the enums with option indexes to opts.h? I find it a bit odd they are in common.h
Yes, this would be nice.
2) Does it make sense to remove the remaining headers (data_provider and common) from opts.h and leave only options in?
No, those are needed for struct dp_option and struct sdap_attr_map at the moment. But we could move definitions of those structures to smaller headers.
On Mon, Dec 07, 2015 at 11:46:38AM +0100, Pavel Březina wrote:
On 12/04/2015 03:51 PM, Jakub Hrozek wrote:
On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
Looks like tests failed: http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
I forgot to run tests... new patches are attached.
Thanks, the patches now build. I have two questions: 1) Since we're moving code around anymore, would it make sense to also move the enums with option indexes to opts.h? I find it a bit odd they are in common.h
Yes, this would be nice.
after an IRC discussion this turned out to be a bit more work than expected, so we can postpone until later..
However, please also change krb5_opts.h in the same way..
On 12/14/2015 10:43 AM, Jakub Hrozek wrote:
On Mon, Dec 07, 2015 at 11:46:38AM +0100, Pavel Březina wrote:
On 12/04/2015 03:51 PM, Jakub Hrozek wrote:
On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote:
This solves situation where you want to use those globals on other place than in *_common.c.
I also created https://fedorahosted.org/sssd/ticket/2890 so we can avoid order-dependency on header files such as sysdb_services.h which I had to fix for AD patch.
Looks like tests failed: http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
I forgot to run tests... new patches are attached.
Thanks, the patches now build. I have two questions: 1) Since we're moving code around anymore, would it make sense to also move the enums with option indexes to opts.h? I find it a bit odd they are in common.h
Yes, this would be nice.
after an IRC discussion this turned out to be a bit more work than expected, so we can postpone until later..
However, please also change krb5_opts.h in the same way..
Attached.
On 12/14/2015 11:39 AM, Pavel Březina wrote:
On 12/14/2015 10:43 AM, Jakub Hrozek wrote:
On Mon, Dec 07, 2015 at 11:46:38AM +0100, Pavel Březina wrote:
On 12/04/2015 03:51 PM, Jakub Hrozek wrote:
On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
On 12/03/2015 11:48 AM, Jakub Hrozek wrote:
On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote: > This solves situation where you want to use those globals on > other place > than in *_common.c. > > I also created https://fedorahosted.org/sssd/ticket/2890 so we > can avoid > order-dependency on header files such as sysdb_services.h which I > had to fix > for AD patch.
Looks like tests failed:
http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te...
I forgot to run tests... new patches are attached.
Thanks, the patches now build. I have two questions: 1) Since we're moving code around anymore, would it make sense to also move the enums with option indexes to opts.h? I find it a bit odd they are in common.h
Yes, this would be nice.
after an IRC discussion this turned out to be a bit more work than expected, so we can postpone until later..
However, please also change krb5_opts.h in the same way..
Attached.
I accidentally did not include the first patch, I'm sending it again, five patches now.
On Mon, Dec 14, 2015 at 11:46:11AM +0100, Pavel Březina wrote:
On 12/14/2015 11:39 AM, Pavel Březina wrote:
On 12/14/2015 10:43 AM, Jakub Hrozek wrote:
On Mon, Dec 07, 2015 at 11:46:38AM +0100, Pavel Březina wrote:
On 12/04/2015 03:51 PM, Jakub Hrozek wrote:
On Thu, Dec 03, 2015 at 12:45:55PM +0100, Pavel Březina wrote:
On 12/03/2015 11:48 AM, Jakub Hrozek wrote: >On Wed, Dec 02, 2015 at 11:58:55AM +0100, Pavel Březina wrote: >>This solves situation where you want to use those globals on >>other place >>than in *_common.c. >> >>I also created https://fedorahosted.org/sssd/ticket/2890 so we >>can avoid >>order-dependency on header files such as sysdb_services.h which I >>had to fix >>for AD patch. > >Looks like tests failed: > >http://sssd-ci.duckdns.org/logs/job/34/17/fedora20/ci-build-debug/ci-make-te... >
I forgot to run tests... new patches are attached.
Thanks, the patches now build. I have two questions: 1) Since we're moving code around anymore, would it make sense to also move the enums with option indexes to opts.h? I find it a bit odd they are in common.h
Yes, this would be nice.
after an IRC discussion this turned out to be a bit more work than expected, so we can postpone until later..
However, please also change krb5_opts.h in the same way..
Attached.
I accidentally did not include the first patch, I'm sending it again, five patches now.
Code-wise ACK, CI is still running..
On Mon, Dec 14, 2015 at 12:08:27PM +0100, Jakub Hrozek wrote:
I accidentally did not include the first patch, I'm sending it again, five patches now.
Code-wise ACK, CI is still running..
CI: http://sssd-ci.duckdns.org/logs/job/34/59/summary.html (the debian failure is unrelated)
On Mon, Dec 14, 2015 at 12:17:54PM +0100, Jakub Hrozek wrote:
On Mon, Dec 14, 2015 at 12:08:27PM +0100, Jakub Hrozek wrote:
I accidentally did not include the first patch, I'm sending it again, five patches now.
Code-wise ACK, CI is still running..
CI: http://sssd-ci.duckdns.org/logs/job/34/59/summary.html (the debian failure is unrelated)
Sorry, that CI link was for a different patch. The correct one is: http://sssd-ci.duckdns.org/logs/job/34/60/summary.html
Pushed to master: * 291a6c8af9759e41cec6f332cb72606ca90768c3 * 676bf6dda60776d9db79dad1c2506c0e57bb5503 * 9e6f8d1c66b4b3543bab67d807bd26f1d6256c75 * f7ea0b1d46197275c87bdc73a6e38a6fd7f855ee * 50310d617e25abf118fbd867cbdc0fbc866277b5 and sssd-1-13: * 713a7da0c39f6d9720d5389d758588af45373fdd * 2ce82341a537e6245b3b5b067f47ee496d754cfe * be05c3f89dca1943c49c2fd0df98dcc524413196 * d215702f46e35b532d67adf6a90ad3bc064555bf * e736ccea59e033a94c2d61236b4c1f54a3ddcd67
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Pavel Březina