On (24/09/15 12:43), Pavel Březina wrote:
From 9b78f37854b8a8747215934cc8e65b7435b60e7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Thu, 24 Sep 2015 12:10:56 +0200 Subject: [PATCH] sss tools: improve option handling
The crash describe by ticket #2802 is caused by providing NULL options in popt and yet trying to iterate over them. Instead of simply testing for NULL this patch creates a new option table table merges several option tables together, thus improving and simplifying usage string.
(This mail is not a review)
I knew why I didn't want to ACK previous patch @see https://lists.fedorahosted.org/pipermail/sssd-devel/2015-August/024580.html
I'm sorry but I could not resist :-)
LS
On 09/24/2015 02:53 PM, Lukas Slebodnik wrote:
On (24/09/15 12:43), Pavel Březina wrote:
From 9b78f37854b8a8747215934cc8e65b7435b60e7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrezina@redhat.com Date: Thu, 24 Sep 2015 12:10:56 +0200 Subject: [PATCH] sss tools: improve option handling
The crash describe by ticket #2802 is caused by providing NULL options in popt and yet trying to iterate over them. Instead of simply testing for NULL this patch creates a new option table table merges several option tables together, thus improving and simplifying usage string.
(This mail is not a review)
I knew why I didn't want to ACK previous patch @see https://lists.fedorahosted.org/pipermail/sssd-devel/2015-August/024580.html
It's not related to the crash.
I'm sorry but I could not resist :-)
Bring it on.
After applying the patch I can't replicate the crash. CI passed: http://sssd-ci.duckdns.org/logs/job/28/11/summary.html
ACK
On (02/10/15 10:38), Pavel Reichl wrote:
After applying the patch I can't replicate the crash. CI passed: http://sssd-ci.duckdns.org/logs/job/28/11/summary.html
ACK
master: * bda8039465a0084fb380e878c8f9ea3e900505ea
sssd-1-13: * 4d5e7e548865bffec5b8656ecb81c73887949c75
LS
sssd-devel@lists.fedorahosted.org
-
Lukas Slebodnik -
Pavel Březina -
Pavel Reichl