URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: opened
PR body: """ When be_ptask is created to monitor backend when SSSD is in offline mode checks are happening in specified intervals:
delay = delay + (sss_rand() % task->random_offset);
New configuration option is introduced in this commit: * refresh_max_random_offset
Using this option allows end client to decide what should be the size of random offset when new interval for probing backend is calculated.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1925608 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +RFE
URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
sumit-bose commented: """ Hi,
just a general comment, please use `sss_rand()`. It makes sure `srand()` is called and would help if we want to use different general purpose random numbers in SSSD.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-808149961
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
elkoniu commented: """
Hi,
just a general comment, please use `sss_rand()`. It makes sure `srand()` is called and would help if we want to use different general purpose random numbers in SSSD.
bye, Sumit
I changed the description from sss_rand() to rand() only for MAN page. Internally implementation is still based on sss_rand(). Btw - can you take look how MAN page modified in this PR looks like for: offline_timeout, offline_timeout_max and refresh_max_random_offset. As they are related to each other I needed to refactor a bit all 3 entries and I am not sure if final description is good enough. """
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-808157134
URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
elkoniu commented: """
It looks good to me.
If you are happy with the result please set Accept flag so Pavel will be able to pick this PR in next merge round :) """
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-810646692
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
elkoniu commented: """ @pbrezina I think this is a candidate for next merging round, it only lacks final ACK. """
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-817653904
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
pbrezina commented: """ @elkoniu Can you also add :feature: and :config: release notes to the commit? E.g.
https://github.com/SSSD/sssd/commit/d09aa174b04a825979f31c61b05239de088a732f https://github.com/SSSD/sssd/commit/fffe3169bb490c4b010b168c639aa6f9b2ec0c52 """
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-818707304
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
elkoniu commented: """
@elkoniu Can you also add :feature: and :config: release notes to the commit? E.g.
[d09aa17](https://github.com/SSSD/sssd/commit/d09aa174b04a825979f31c61b05239de088a732f) [fffe316](https://github.com/SSSD/sssd/commit/fffe3169bb490c4b010b168c639aa6f9b2ec0c52)
Hi, I just updated it. Let me know if it meets requirements (indention, form etc.) """
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-819386850
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5549
* `master` * 191b53529700f5d92f3db37b270ed624c53cbaa7 - data_provider: Configure backend probing interval
"""
See the full comment at https://github.com/SSSD/sssd/pull/5549#issuecomment-820229763
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5549 Title: #5549: data_provider: Configure backend probing interval
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5549 Author: elkoniu Title: #5549: data_provider: Configure backend probing interval Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5549/head:pr5549 git checkout pr5549
sssd-devel@lists.fedorahosted.org
-
elkoniu -
ikerexxe
-
pbrezina
-
sumit-bose