[sssd PR#694][opened] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Author: thalman
 Title: #694: SSSCTL: user-show says that user is expired
Action: opened

PR body:
"""
sssctl user-show says that user is expired if the user comes from files
provider. This is ok because files user's expiration time is always set
to 0 but we should print a better, less confusing message.

The same change apply to groups.

Resolves:
https://pagure.io/SSSD/sssd/issue/3858
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/694/head:pr694
git checkout pr694

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

pbrezina commented:
"""
This works well but there is one corner case that will print "Expired" instead of "Never". If you will run `sss_cache -U` to invalidate all users (or `sss_cache -u` to invalidate single user from files domain) it will set data expiration time to 1 which will get past your check.

We do not have anything like "never expire" for ldap objects (expiration time < current time means that the object is expired and needs to be updated, this apply for expiration time = 0 as well). This is special case for files provider therefore I'd rather check `sss_domain_info->provider == "files"` instead of the expiration time itself.
"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-439030260

[sssd PR#694][+Changes requested] SSSCTL: user-show says that user is expired

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

Label: +Changes requested

[sssd PR#694][synchronized] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Author: thalman
 Title: #694: SSSCTL: user-show says that user is expired
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/694/head:pr694
git checkout pr694

[sssd PR#694][-Changes requested] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

Label: -Changes requested

[sssd PR#694][synchronized] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Author: thalman
 Title: #694: SSSCTL: user-show says that user is expired
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/694/head:pr694
git checkout pr694

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

thalman commented:
"""
Updated.
"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-439407410

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

pbrezina commented:
"""
I think you can simplify the condition to:
```
+    if (strcasecmp(dom->provider, "files") == 0) {
+        *_value = "Never";
+        return EOK;
+    }
```
"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-440641917

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

sumit-bose commented:
"""
> I think you can simplify the condition to:
> +    if (strcasecmp(dom->provider, "files") == 0) {

jfyi, there is is_files_provider() as well.
>    *_value = "Never";
>    return EOK;
> }

"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-440680104

[sssd PR#694][+Changes requested] SSSCTL: user-show says that user is expired

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

Label: +Changes requested

[sssd PR#694][synchronized] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Author: thalman
 Title: #694: SSSCTL: user-show says that user is expired
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/694/head:pr694
git checkout pr694

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[thalman]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

thalman commented:
"""
Thanks for comments. PR updated.
"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-441025815

[sssd PR#694][-Changes requested] SSSCTL: user-show says that user is expired

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

Label: -Changes requested

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

pbrezina commented:
"""
Thank you. Ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-441055972

[sssd PR#694][+Accepted] SSSCTL: user-show says that user is expired

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

Label: +Accepted

[sssd PR#694][closed] SSSCTL: user-show says that user is expired

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/694
Author: thalman
 Title: #694: SSSCTL: user-show says that user is expired
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/694/head:pr694
git checkout pr694

[sssd PR#694][comment] SSSCTL: user-show says that user is expired

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

jhrozek commented:
"""
* master: 291071cb3c04eda7606d62bbff123a0a125c7d60
"""

See the full comment at https://github.com/SSSD/sssd/pull/694#issuecomment-441124198

[sssd PR#694][+Pushed] SSSCTL: user-show says that user is expired

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/694
Title: #694: SSSCTL: user-show says that user is expired

Label: +Pushed