[PATCH] IPA: Remove unused memory context

[Lukas Slebodnik]

ehlo,

While I was working on another isuue I found unused paraeter.

Simple patch is attached

LS

[Jakub Hrozek]

On Mon, Oct 21, 2013 at 05:23:06PM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> While I was working on another isuue I found unused paraeter.
>
> Simple patch is attached
>
> LS
> From 64c8b6839b6de63f8e3fb9995a16351f82ba96c1 Mon Sep 17 00:00:00 2001
> From: Lukas Slebodnik 
> Date: Mon, 21 Oct 2013 17:18:27 +0200
> Subject: [PATCH] IPA: Remove unused memory context.
>
> Parameter mem_ctx was unused in static function
> get_password_migration_flag_recv
>
> src/providers/ipa/ipa_auth.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/providers/ipa/ipa_auth.c b/src/providers/ipa/ipa_auth.c
> index 3db623f11c3e255d76a99498709ff571584d5f98..c723fea7f221f3e71bb2f4fb9ec39efbb161f878 100644
> --- a/src/providers/ipa/ipa_auth.c
> +++ b/src/providers/ipa/ipa_auth.c
> @@ -157,7 +157,6 @@ done:
>  }
>
> static int get_password_migration_flag_recv(struct tevent_req *req,
>                                        TALLOC_CTX *mem_ctx,
>                                        bool *password_migration)
>
> {
>      struct get_password_migration_flag_state *state = tevent_req_data(req,
> @@ -290,8 +289,7 @@ static void ipa_get_migration_flag_done(struct tevent_req *req)
>      int ret;
>      int dp_err = DP_ERR_FATAL;
> ret = get_password_migration_flag_recv(req, state,
>                                       &state->password_migration);
> ret = get_password_migration_flag_recv(req, &state->password_migration);
> talloc_zfree(req);
> if (ret != EOK) {
>     DEBUG(SSSDBG_OP_FAILURE, ("get_password_migration_flag "
>
> -- 
> 1.8.3.1

ACK

I haven't tested the password migration itself but given the patch
complexity, I think that running just "make" and "make check" is OK.

[Jakub Hrozek]

On Mon, Oct 21, 2013 at 10:51:53PM +0200, Jakub Hrozek wrote:
> On Mon, Oct 21, 2013 at 05:23:06PM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > While I was working on another isuue I found unused paraeter.
> >
> > Simple patch is attached
> >
> > LS
> > From 64c8b6839b6de63f8e3fb9995a16351f82ba96c1 Mon Sep 17 00:00:00 2001
> > From: Lukas Slebodnik 
> > Date: Mon, 21 Oct 2013 17:18:27 +0200
> > Subject: [PATCH] IPA: Remove unused memory context.
> >
> > Parameter mem_ctx was unused in static function
> > get_password_migration_flag_recv
> >
> > src/providers/ipa/ipa_auth.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/src/providers/ipa/ipa_auth.c b/src/providers/ipa/ipa_auth.c
> > index 3db623f11c3e255d76a99498709ff571584d5f98..c723fea7f221f3e71bb2f4fb9ec39efbb161f878 100644
> > --- a/src/providers/ipa/ipa_auth.c
> > +++ b/src/providers/ipa/ipa_auth.c
> > @@ -157,7 +157,6 @@ done:
> >  }
> >
> > static int get_password_migration_flag_recv(struct tevent_req *req,
> >                                        TALLOC_CTX *mem_ctx,
> >                                        bool *password_migration)
> >
> > {
> >      struct get_password_migration_flag_state *state = tevent_req_data(req,
> > @@ -290,8 +289,7 @@ static void ipa_get_migration_flag_done(struct tevent_req *req)
> >      int ret;
> >      int dp_err = DP_ERR_FATAL;
> > ret = get_password_migration_flag_recv(req, state,
> >                                       &state->password_migration);
> > ret = get_password_migration_flag_recv(req, &state->password_migration);
> > talloc_zfree(req);
> > if (ret != EOK) {
> >     DEBUG(SSSDBG_OP_FAILURE, ("get_password_migration_flag "
> >
> > -- 
> > 1.8.3.1
>
> ACK
>
> I haven't tested the password migration itself but given the patch
> complexity, I think that running just "make" and "make check" is OK.

Pushed to master.