[PATCHES] idmap: add API to free allocated SIDs - sssd-devel - Fedora Mailing-Lists

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

[PATCHES] idmap: add API to free allocated SIDs

German po4a translation

[PATCH] Add an option to disable...

Pavel Březina

Monday, 4 November 2013 Mon, 4 Nov '13

5:13 a.m.

https://fedorahosted.org/sssd/ticket/2133

Attachments:

0001-idmap-add-API-to-free-allocated-SIDs.patch (text/x-patch — 3.3 KB)
0002-free-idmapped-SIDs-correctly.patch (text/x-patch — 7.5 KB)
0003-free-idmapped-dom-SIDs-correctly.patch (text/x-patch — 2.4 KB)
0004-free-idmapped-smb-SIDs-correctly.patch (text/x-patch — 1.4 KB)
0005-Bump-sss_idmap-version-to-3-0-3.patch (text/x-patch — 796 bytes)

Reply

Show replies by date

Sumit Bose

Monday, 4 November Mon, 4 Nov

8:03 a.m.

On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote:

https://fedorahosted.org/sssd/ticket/2133

Patches are looking good, I wonder why you did not cover binary SIDs, i.e. *_to_bin_sid() calls? bye, Sumit

Reply

Jakub Hrozek

8:40 a.m.

On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote:

On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/2133 Patches are looking good, I wonder why you did not cover binary SIDs, i.e. *_to_bin_sid() calls? bye, Sumit

I would also prefer not to commit the last patch until the time of release to avoid having to bump the version info if we did more changes to the library.

Reply

Lukas Slebodnik

8:47 a.m.

On (04/11/13 15:40), Jakub Hrozek wrote:

On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote: > On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > > https://fedorahosted.org/sssd/ticket/2133 > > Patches are looking good, I wonder why you did not cover binary SIDs, > i.e. *_to_bin_sid() calls? > > bye, > Sumit I would also prefer not to commit the last patch until the time of release to avoid having to bump the version info if we did more changes to the library.

I agree. version-info should be updated only once before official release, but we can add TODO comment into Makefile.am. "#TODO: update version-info before release" LS

Reply

Stephen Gallagher

1:46 p.m.

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/04/2013 09:47 AM, Lukas Slebodnik wrote:

On (04/11/13 15:40), Jakub Hrozek wrote: > On Mon, Nov 04, 2013 at 03:03:04PM +0100, Sumit Bose wrote: >> On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: >>> https://fedorahosted.org/sssd/ticket/2133 >> >> Patches are looking good, I wonder why you did not cover binary >> SIDs, i.e. *_to_bin_sid() calls? >> >> bye, Sumit > > I would also prefer not to commit the last patch until the time > of release to avoid having to bump the version info if we did > more changes to the library. I agree. version-info should be updated only once before official release, but we can add TODO comment into Makefile.am. "#TODO: update version-info before release"

In order to track these sorts of changes, perhaps just file an upstream blocker ticket targeted at the release to make sure it gets remembered? It's pretty easy to miss a TODO in a file we only read rarely.

...PGP SIGNATURE...

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJ3+a8ACgkQeiVVYja6o6NSQwCfY6Snav7NVa8NFKXH1pKZuAe8 7scAnjZoxiXJEqvsV0oLkFD+CFcgCGQ4 =KaIv -----END PGP SIGNATURE-----

Reply

Pavel Březina

9:39 a.m.

----- Original Message -----

From: "Sumit Bose" <sbose(a)redhat.com> To: sssd-devel(a)lists.fedorahosted.org Sent: Monday, November 4, 2013 3:03:04 PM Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/2133

Hi, thanks for the review.

Patches are looking good, I wonder why you did not cover binary SIDs, i.e. *_to_bin_sid() calls?

Ha, I knew I forgot something. I'll send another version that will include binary SIDs.

bye, Sumit

Reply

Pavel Březina

Tuesday, 5 November Tue, 5 Nov

5:29 a.m.

On 11/04/2013 04:39 PM, Pavel Brezina wrote:

----- Original Message ----- > From: "Sumit Bose" <sbose(a)redhat.com> > To: sssd-devel(a)lists.fedorahosted.org > Sent: Monday, November 4, 2013 3:03:04 PM > Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs > > On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: >> https://fedorahosted.org/sssd/ticket/2133 > Hi, thanks for the review. > Patches are looking good, I wonder why you did not cover binary SIDs, > i.e. *_to_bin_sid() calls? Ha, I knew I forgot something. I'll send another version that will include binary SIDs.

New patches are attached.

Reply

Sumit Bose

Wednesday, 6 November Wed, 6 Nov

3:16 a.m.

On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote:

On 11/04/2013 04:39 PM, Pavel Brezina wrote: > > >----- Original Message ----- >>From: "Sumit Bose" <sbose(a)redhat.com> >>To: sssd-devel(a)lists.fedorahosted.org >>Sent: Monday, November 4, 2013 3:03:04 PM >>Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs >> >>On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: >>>https://fedorahosted.org/sssd/ticket/2133 >> > >Hi, >thanks for the review. > >>Patches are looking good, I wonder why you did not cover binary SIDs, >>i.e. *_to_bin_sid() calls? > >Ha, I knew I forgot something. I'll send another version that will include binary SIDs. New patches are attached.

ACK for 1-5. I think Jakub should decide how to handle the updates of the version-info. bye, Sumit

Reply

Jakub Hrozek

Thursday, 7 November Thu, 7 Nov

3:59 a.m.

On Wed, Nov 06, 2013 at 10:16:58AM +0100, Sumit Bose wrote:

On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote: > On 11/04/2013 04:39 PM, Pavel Brezina wrote: > > > > > >----- Original Message ----- > >>From: "Sumit Bose" <sbose(a)redhat.com> > >>To: sssd-devel(a)lists.fedorahosted.org > >>Sent: Monday, November 4, 2013 3:03:04 PM > >>Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs > >> > >>On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > >>>https://fedorahosted.org/sssd/ticket/2133 > >> > > > >Hi, > >thanks for the review. > > > >>Patches are looking good, I wonder why you did not cover binary SIDs, > >>i.e. *_to_bin_sid() calls? > > > >Ha, I knew I forgot something. I'll send another version that will include binary SIDs. > > New patches are attached. > ACK for 1-5. I think Jakub should decide how to handle the updates of the version-info. bye, Sumit

I filed https://fedorahosted.org/sssd/ticket/2145 as Stephen suggested to track pushing the last patch.

Reply

Jakub Hrozek

Thursday, 19 December Thu, 19 Dec

10:51 a.m.

On Thu, Nov 07, 2013 at 10:59:04AM +0100, Jakub Hrozek wrote:

On Wed, Nov 06, 2013 at 10:16:58AM +0100, Sumit Bose wrote: > On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote: > > On 11/04/2013 04:39 PM, Pavel Brezina wrote: > > > > > > > > >----- Original Message ----- > > >>From: "Sumit Bose" <sbose(a)redhat.com> > > >>To: sssd-devel(a)lists.fedorahosted.org > > >>Sent: Monday, November 4, 2013 3:03:04 PM > > >>Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs > > >> > > >>On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > > >>>https://fedorahosted.org/sssd/ticket/2133 > > >> > > > > > >Hi, > > >thanks for the review. > > > > > >>Patches are looking good, I wonder why you did not cover binary SIDs, > > >>i.e. *_to_bin_sid() calls? > > > > > >Ha, I knew I forgot something. I'll send another version that will include binary SIDs. > > > > New patches are attached. > > > > ACK for 1-5. I think Jakub should decide how to handle the updates of > the version-info. > > bye, > Sumit I filed https://fedorahosted.org/sssd/ticket/2145 as Stephen suggested to track pushing the last patch.

The patch to fix to bump the version info was pushed to master and sssd-1-11

Reply

Jakub Hrozek

Thursday, 7 November Thu, 7 Nov

4:06 a.m.

On Wed, Nov 06, 2013 at 10:16:58AM +0100, Sumit Bose wrote:

On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote: > On 11/04/2013 04:39 PM, Pavel Brezina wrote: > > > > > >----- Original Message ----- > >>From: "Sumit Bose" <sbose(a)redhat.com> > >>To: sssd-devel(a)lists.fedorahosted.org > >>Sent: Monday, November 4, 2013 3:03:04 PM > >>Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs > >> > >>On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: > >>>https://fedorahosted.org/sssd/ticket/2133 > >> > > > >Hi, > >thanks for the review. > > > >>Patches are looking good, I wonder why you did not cover binary SIDs, > >>i.e. *_to_bin_sid() calls? > > > >Ha, I knew I forgot something. I'll send another version that will include binary SIDs. > > New patches are attached. > ACK for 1-5. I think Jakub should decide how to handle the updates of the version-info.

Pushed 1-5 to master. Pavel, can you resend patch #5 without the cifs_idmap_sss.c hunk so I can push to 1.11 as well?

Reply

Pavel Březina

4:10 a.m.

On 11/07/2013 11:06 AM, Jakub Hrozek wrote:

On Wed, Nov 06, 2013 at 10:16:58AM +0100, Sumit Bose wrote: > On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote: >> On 11/04/2013 04:39 PM, Pavel Brezina wrote: >>> >>> >>> ----- Original Message ----- >>>> From: "Sumit Bose" <sbose(a)redhat.com> >>>> To: sssd-devel(a)lists.fedorahosted.org >>>> Sent: Monday, November 4, 2013 3:03:04 PM >>>> Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs >>>> >>>> On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: >>>>> https://fedorahosted.org/sssd/ticket/2133 >>>> >>> >>> Hi, >>> thanks for the review. >>> >>>> Patches are looking good, I wonder why you did not cover binary SIDs, >>>> i.e. *_to_bin_sid() calls? >>> >>> Ha, I knew I forgot something. I'll send another version that will include binary SIDs. >> >> New patches are attached. >> > > ACK for 1-5. I think Jakub should decide how to handle the updates of > the version-info. Pushed 1-5 to master. Pavel, can you resend patch #5 without the cifs_idmap_sss.c hunk so I can push to 1.11 as well?

Sure. See attachments.

Reply

Jakub Hrozek

4:20 a.m.

On Thu, Nov 07, 2013 at 11:10:42AM +0100, Pavel Březina wrote:

On 11/07/2013 11:06 AM, Jakub Hrozek wrote: >On Wed, Nov 06, 2013 at 10:16:58AM +0100, Sumit Bose wrote: >>On Tue, Nov 05, 2013 at 12:29:25PM +0100, Pavel Březina wrote: >>>On 11/04/2013 04:39 PM, Pavel Brezina wrote: >>>> >>>> >>>>----- Original Message ----- >>>>>From: "Sumit Bose" <sbose(a)redhat.com> >>>>>To: sssd-devel(a)lists.fedorahosted.org >>>>>Sent: Monday, November 4, 2013 3:03:04 PM >>>>>Subject: Re: [SSSD] [PATCHES] idmap: add API to free allocated SIDs >>>>> >>>>>On Mon, Nov 04, 2013 at 12:13:52PM +0100, Pavel Březina wrote: >>>>>>https://fedorahosted.org/sssd/ticket/2133 >>>>> >>>> >>>>Hi, >>>>thanks for the review. >>>> >>>>>Patches are looking good, I wonder why you did not cover binary SIDs, >>>>>i.e. *_to_bin_sid() calls? >>>> >>>>Ha, I knew I forgot something. I'll send another version that will include binary SIDs. >>> >>>New patches are attached. >>> >> >>ACK for 1-5. I think Jakub should decide how to handle the updates of >>the version-info. > >Pushed 1-5 to master. > >Pavel, can you resend patch #5 without the cifs_idmap_sss.c hunk so I >can push to 1.11 as well? Sure. See attachments.

ACK and pushed to sssd-1-11

Reply

3785

days inactive

3830

days old

sssd-devel@lists.fedorahosted.org

Manage subscription

12 comments

5 participants

tags (0)

participants (5)

Jakub Hrozek
Lukas Slebodnik
Pavel Březina
Stephen Gallagher
Sumit Bose