[PATCH] CIFS idmap Plugin using SSSD

[Benjamin Franzke]

Hello list,

I've started to implement a plugin for the cifs-utils idmap interface.
Currently it lives in an own repository and can be build outside the sssd
tree, thanks to the public sssd libraries libsss_idmap.so and
libsss_nss_idmap.so:

http://git.bnfr.net/cifs_idmap_sss/tree/cifs_idmap_sss.c
git://git.bnfr.net/cifs_idmap_sss

Still missing is the mapping of Samba's Unix SIDs and some well known SIDs
(more info in cifs_idmap_sss.c)

Are you intrested in reviewing it and/or have it included in the sssd git
tree or somehow else as a sssd project?

Thanks, Ben

[Jakub Hrozek]

On Thu, Oct 03, 2013 at 06:14:41PM +0200, Benjamin Franzke wrote:
> Hello list,
>
> I've started to implement a plugin for the cifs-utils idmap interface.
> Currently it lives in an own repository and can be build outside the sssd
> tree, thanks to the public sssd libraries libsss_idmap.so and
> libsss_nss_idmap.so:
>
> http://git.bnfr.net/cifs_idmap_sss/tree/cifs_idmap_sss.c
> git://git.bnfr.net/cifs_idmap_sss
>
> Still missing is the mapping of Samba's Unix SIDs and some well known SIDs
> (more info in cifs_idmap_sss.c)
>
> Are you intrested in reviewing it and/or have it included in the sssd git
> tree or somehow else as a sssd project?
>
> Thanks, Ben

Hi Ben,

this is really great, thank you very much for the contribution! As a
matter of fact, we've been planning on delivering the CIFS plugin as
part of the next release:
https://fedorahosted.org/sssd/ticket/1534

Have you found the design page we created?
https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient

Mostly the work on our side was done by Sumit Bose (I've CC-ed him). I
would propose to get in touch with him to avoid duplicating some effort.
Unfortunately Sumit is in Germany and there is a holiday so he won't be
available until Monday.

In general, I would suggest to merge this code into the SSSD tree if you
wouldn't mind. I think it would makes sense to have the code in the same
repo as the ID mapping library.

Thanks again for the contribution, much appreciated!

[Benjamin Franzke]

> Hi Ben,
>
> this is really great, thank you very much for the contribution! As a
> matter of fact, we've been planning on delivering the CIFS plugin as
> part of the next release:
> https://fedorahosted.org/sssd/ticket/1534
>
> Have you found the design page we created?
> https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient

Yeah, I've read those pages before writing the plugin..
> Mostly the work on our side was done by Sumit Bose (I've CC-ed him). I
> would propose to get in touch with him to avoid duplicating some effort.

Unfortunately Sumit is in Germany and there is a holiday so he won't be
> available until Monday.
> In general, I would suggest to merge this code into the SSSD tree if you
> wouldn't mind. I think it would makes sense to have the code in the same
> repo as the ID mapping library.

I'd really appreciate having it integrated in sssd tree,
to have centralized maintainance and adoption by distributions..
> Thanks again for the contribution, much appreciated!
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Sumit Bose]

On Thu, Oct 03, 2013 at 11:57:07PM +0200, Benjamin Franzke wrote:
> > Hi Ben,
> >
> > this is really great, thank you very much for the contribution! As a
> > matter of fact, we've been planning on delivering the CIFS plugin as
> > part of the next release:
> > https://fedorahosted.org/sssd/ticket/1534
> >
> > Have you found the design page we created?
> > https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient
>
> Yeah, I've read those pages before writing the plugin..
> > Mostly the work on our side was done by Sumit Bose (I've CC-ed him). I
> > would propose to get in touch with him to avoid duplicating some effort.
>
> Unfortunately Sumit is in Germany and there is a holiday so he won't be
> > available until Monday.
> > In general, I would suggest to merge this code into the SSSD tree if you
> > wouldn't mind. I think it would makes sense to have the code in the same
> > repo as the ID mapping library.
>
> I'd really appreciate having it integrated in sssd tree,
> to have centralized maintainance and adoption by distributions..

Thanks a lot for the patch. I would suggest to put your code into
src/lib/cifs_idmap_sss/ and modify SSSD's Makefile.am to build the
plugin. Would you like to do the integration and send the result for
review to this list again?

About the well-know SIDs. They should not be handled inside the plugin
but by SSSD itself. If you are interested in adding them I'd be happy to
help you how to start (if my help is needed at all :-).

bye,
Sumit
> > Thanks again for the contribution, much appreciated!
> > _______________________________________________
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Benjamin Franzke]

2013/10/7 Sumit Bose
> On Thu, Oct 03, 2013 at 11:57:07PM +0200, Benjamin Franzke wrote:
> > > Hi Ben,
> > >
> > > this is really great, thank you very much for the contribution! As a
> > > matter of fact, we've been planning on delivering the CIFS plugin as
> > > part of the next release:
> > > https://fedorahosted.org/sssd/ticket/1534
> > >
> > > Have you found the design page we created?
>
> https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient
> > Yeah, I've read those pages before writing the plugin..
> > > Mostly the work on our side was done by Sumit Bose (I've CC-ed him). I
> > > would propose to get in touch with him to avoid duplicating some
>
> effort.
> > >
> >
> > Unfortunately Sumit is in Germany and there is a holiday so he won't be
> > > available until Monday.
> > > In general, I would suggest to merge this code into the SSSD tree if
>
> you
> > > wouldn't mind. I think it would makes sense to have the code in the
>
> same
> > > repo as the ID mapping library.
> >
> > I'd really appreciate having it integrated in sssd tree,
> > to have centralized maintainance and adoption by distributions..
>
> Thanks a lot for the patch. I would suggest to put your code into
> src/lib/cifs_idmap_sss/ and modify SSSD's Makefile.am to build the
> plugin. Would you like to do the integration and send the result for
> review to this list again?

I'd like to do that integration, will send a patch..
> About the well-know SIDs. They should not be handled inside the plugin
> but by SSSD itself. If you are interested in adding them I'd be happy to
> help you how to start (if my help is needed at all :-).

Yup, sounds better to handle the SIDs by SSSD core. I'd like to try..
I'll see whether time permits me to do that soon.. (doing this as a part of
my thesis)
> bye,
> Sumit
> > > Thanks again for the contribution, much appreciated!
> > > _______________________________________________
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel