[PATCH] SSSDConfig: Return correct types in python3

[Lukas Slebodnik]

ehlo,

attached patch fixes ticket #2699

On other places we do not require to return list by dict.keys().
There were patterns:
    something in a_dictionary.keys()
    ", ".join(a_dictionary.keys()))

LS

[Christian Heimes]

On 2015-08-04 15:13, Lukas Slebodnik wrote:
>  ehlo,
>  
>  attached patch fixes ticket #2699
>  
>  On other places we do not require to return list by dict.keys().
>  There were patterns:
>      something in a_dictionary.keys()
>      ", ".join(a_dictionary.keys())) 
You don't have to call the keys() method at all. list(a_dict) gives you
a list of keys on all versions of Python. If you need a sorted list, you
can use sorted(a_dict). These days the keys() method is considered bad
style.

Christian

[Lukas Slebodnik]

On (04/08/15 15:20), Christian Heimes wrote:
> On 2015-08-04 15:13, Lukas Slebodnik wrote:
> > ehlo,
> > 
> > attached patch fixes ticket #2699
> > 
> > On other places we do not require to return list by dict.keys().
> > There were patterns:
> >     something in a_dictionary.keys()
> >     ", ".join(a_dictionary.keys()))
>
> You don't have to call the keys() method at all. list(a_dict) gives you
> a list of keys on all versions of Python. If you need a sorted list, you
> can use sorted(a_dict). These days the keys() method is considered bad
> style.
>  
Updated patch is attached.

LS

[Christian Heimes]

On 2015-08-04 15:26, Lukas Slebodnik wrote:
>  On (04/08/15 15:20), Christian Heimes wrote:
> > On 2015-08-04 15:13, Lukas Slebodnik wrote:
> >> ehlo,
> >>
> >> attached patch fixes ticket #2699
> >>
> >> On other places we do not require to return list by dict.keys().
> >> There were patterns:
> >>     something in a_dictionary.keys()
> >>     ", ".join(a_dictionary.keys()))
> >
> > You don't have to call the keys() method at all. list(a_dict) gives you
> > a list of keys on all versions of Python. If you need a sorted list, you
> > can use sorted(a_dict). These days the keys() method is considered bad
> > style.
> >
>  Updated patch is attached. 
ACK

hint:
You can use assertIsInstance() in the unit test. Python 2.7 has some
more useful test case methods, e.g. assertListEqual().

https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertI...
https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertL...

[Jakub Hrozek]

On Tue, Aug 04, 2015 at 04:12:43PM +0200, Christian Heimes wrote:
>  > Updated patch is attached.
>  
>  ACK 
Thanks a lot for the review!

* master: 2ab9822a792e26e9ddb47cbb6bc788a0727c8556

[Lukas Slebodnik]

On (04/08/15 16:12), Christian Heimes wrote:
> On 2015-08-04 15:26, Lukas Slebodnik wrote:
> > On (04/08/15 15:20), Christian Heimes wrote:
> >> On 2015-08-04 15:13, Lukas Slebodnik wrote:
> >>> ehlo,
> >>>
> >>> attached patch fixes ticket #2699
> >>>
> >>> On other places we do not require to return list by dict.keys().
> >>> There were patterns:
> >>>     something in a_dictionary.keys()
> >>>     ", ".join(a_dictionary.keys()))
> >>
> >> You don't have to call the keys() method at all. list(a_dict) gives you
> >> a list of keys on all versions of Python. If you need a sorted list, you
> >> can use sorted(a_dict). These days the keys() method is considered bad
> >> style.
> >>
> > Updated patch is attached.
>
> ACK
>
> hint:
> You can use assertIsInstance() in the unit test. Python 2.7 has some
> more useful test case methods, e.g. assertListEqual().
>  
The biggest problem is with python 2.6 which is on rhel6
So I could not use it.

LS