URL: https://github.com/SSSD/sssd/pull/568 Author: malyzelenyhnus Title: #568: Strip whitespaces in netgroup triple. Action: opened
PR body: """ Strip leading and trailing whitespaces from netgroup three-tuple strings to be compatible with nss_ldap. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/568/head:pr568 git checkout pr568
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-387093683
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-387093684
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
fidencio commented: """ okay to test """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-387109816
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-387495148
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ Just a quick note because the PR did not get any review for three weeks now -- I checked the code when it was submitted and it looks OK after a visual inspection. I was going to write a test to make sure splitting the triples works, but I (and others on our team) were swamped with unexpected urgent work, so I did not have the time to finish the test.
So, I'm sorry this PR got stalled, it's on my list to get back to it. Thank you very much for the contribution. """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-392443260
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ I'm sorry it took me two months to get to the review. I found one minor issue where you left some unused variables after the refactoring and wrote a unit test. Both commits are in my netgrtest branch. If you agree, could you cherry-pick and squash the patch that removes the unused variables? Then I'd push your patch and submit the test separately. """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-406327234
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ removing variables: https://github.com/jhrozek/sssd/commit/a6fd80a28bc4011ee0828f2bb66454d79a661... unit test: https://github.com/jhrozek/sssd/commit/ca91f4f2c9ea7c490a7d556cf06451ce11cd6... """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-406327613
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ btw I'm setting changes requested to this PR because the unused variables should be squashed. I can do that myself as well if you don't have the time (I hope you didn't get too irritated about the long response time in the meantime..) """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-406604750
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/568 Author: malyzelenyhnus Title: #568: Strip whitespaces in netgroup triple. Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/568/head:pr568 git checkout pr568
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ Thank you, ack """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-408803125
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ * master: dbb1abae6eaa9df24f61e3a9f855e2461a66a197 """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-408991053
URL: https://github.com/SSSD/sssd/pull/568 Author: malyzelenyhnus Title: #568: Strip whitespaces in netgroup triple. Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/568/head:pr568 git checkout pr568
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/568 Title: #568: Strip whitespaces in netgroup triple.
jhrozek commented: """ Thank you very much for the contribution and sorry for the huge delay in review. """
See the full comment at https://github.com/SSSD/sssd/pull/568#issuecomment-408991210
sssd-devel@lists.fedorahosted.org
-
centos-ci -
fidencio
-
jhrozek
-
malyzelenyhnus