[PATCH] make ldap provider a little bit more resistant to errors

[Simo Sorce]

I was seeing in some non-easily reproduceable cases errors returned by
ldap_search_ext() that would hose the connection. The same connection
handler would be used after the offline timeout causing again the same
error (and us going offline again).
This patch should fix it or at least make the code a bit more resilient
to this kind of errors.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote:
>  I was seeing in some non-easily reproduceable cases errors returned
> by
>  ldap_search_ext() that would hose the connection. The same connection
>  handler would be used after the offline timeout causing again the same
>  error (and us going offline again).
>  This patch should fix it or at least make the code a bit more resilient
>  to this kind of errors. 
Self NACK while temporarily investigating a segfault possibly related to
ctx->gsh sometimes not being a vaild pointer ... will respin later.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Mon, 2009-10-26 at 20:15 -0400, Simo Sorce wrote:
>  On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote:
>  > I was seeing in some non-easily reproduceable cases errors returned by
>  > ldap_search_ext() that would hose the connection. The same connection
>  > handler would be used after the offline timeout causing again the same
>  > error (and us going offline again).
>  > This patch should fix it or at least make the code a bit more resilient
>  > to this kind of errors.
>  
>  Self NACK while temporarily investigating a segfault possibly related to
>  ctx->gsh sometimes not being a vaild pointer ... will respin later. 
ok found the error, calling mark_offline from within mark_offline,
recursively was not a very bright idea :-)

Attached, new patch that calls the right function (be_mark_offline).

-- 
Simo Sorce * Red Hat, Inc * New York

[Simo Sorce]

On Mon, 2009-10-26 at 20:20 -0400, Simo Sorce wrote:
>  On Mon, 2009-10-26 at 20:15 -0400, Simo Sorce wrote:
>  > On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote:
>  > > I was seeing in some non-easily reproduceable cases errors returned by
>  > > ldap_search_ext() that would hose the connection. The same connection
>  > > handler would be used after the offline timeout causing again the same
>  > > error (and us going offline again).
>  > > This patch should fix it or at least make the code a bit more resilient
>  > > to this kind of errors.
>  > 
>  > Self NACK while temporarily investigating a segfault possibly related to
>  > ctx->gsh sometimes not being a vaild pointer ... will respin later.
>  
>  ok found the error, calling mark_offline from within mark_offline,
>  recursively was not a very bright idea :-)
>  
>  Attached, new patch that calls the right function (be_mark_offline). 
This time with the correct author after I fixed my new .gitconfig
file...

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/27/2009 09:54 AM, Simo Sorce wrote:
>  On Mon, 2009-10-26 at 20:20 -0400, Simo Sorce wrote:
> > On Mon, 2009-10-26 at 20:15 -0400, Simo Sorce wrote:
> >> On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote:
> >>> I was seeing in some non-easily reproduceable cases errors returned by
> >>> ldap_search_ext() that would hose the connection. The same connection
> >>> handler would be used after the offline timeout causing again the same
> >>> error (and us going offline again).
> >>> This patch should fix it or at least make the code a bit more resilient
> >>> to this kind of errors.
> >>
> >> Self NACK while temporarily investigating a segfault possibly related to
> >> ctx->gsh sometimes not being a vaild pointer ... will respin later.
> >
> > ok found the error, calling mark_offline from within mark_offline,
> > recursively was not a very bright idea :-)
> >
> > Attached, new patch that calls the right function (be_mark_offline).
>  
>  This time with the correct author after I fixed my new .gitconfig
>  file...
>  
>  Simo.
>  
>  
>  
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel 
Ack

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkromi8ACgkQeiVVYja6o6M6SQCdEWX+IbmamWXpYUrfBqw1eG2D
> IxAAnjB25FesVFgEEx1MmuKtCS6zmUAU
> =YX/0
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/28/2009 03:23 PM, Stephen Gallagher wrote:
>  On 10/27/2009 09:54 AM, Simo Sorce wrote:
> > On Mon, 2009-10-26 at 20:20 -0400, Simo Sorce wrote:
> >> On Mon, 2009-10-26 at 20:15 -0400, Simo Sorce wrote:
> >>> On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote:
> >>>> I was seeing in some non-easily reproduceable cases errors returned by
> >>>> ldap_search_ext() that would hose the connection. The same connection
> >>>> handler would be used after the offline timeout causing again the same
> >>>> error (and us going offline again).
> >>>> This patch should fix it or at least make the code a bit more resilient
> >>>> to this kind of errors.
> >>>
> >>> Self NACK while temporarily investigating a segfault possibly related to
> >>> ctx->gsh sometimes not being a vaild pointer ... will respin later.
> >>
> >> ok found the error, calling mark_offline from within mark_offline,
> >> recursively was not a very bright idea :-)
> >>
> >> Attached, new patch that calls the right function (be_mark_offline).
>  
> > This time with the correct author after I fixed my new .gitconfig
> > file...
>  
> > Simo.
>  
>  
>  
>  
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>  
>  Ack
>   
Pushed to master.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkrooxQACgkQeiVVYja6o6OmmACfXW7+dHoxjhik4dj1Fyo7cjqX
> CdIAn08YdSWD1urqkZrQURuUMTOIOdv9
> =YKKe
> -----END PGP SIGNATURE-----