[PATCH] ldap, krb5: More descriptive msg on chpass failure.

[Michal Židek]

During password change operation if wrong current password was given
we gave no hint to the user about what went wrong. The "Authentication
token manipulation error" message alone was not very descriptive.

resolves:
https://fedorahosted.org/sssd/ticket/2029

Thanks
Michal

[Jakub Hrozek]

On Fri, Aug 09, 2013 at 09:44:06PM +0200, Michal Židek wrote:
> During password change operation if wrong current password was given
> we gave no hint to the user about what went wrong. The "Authentication
> token manipulation error" message alone was not very descriptive.
>
> resolves:
> https://fedorahosted.org/sssd/ticket/2029
>
> Thanks
> Michal

Works fine:

su - tuser
Password: 
Last login: Sun Aug 11 20:29:44 CEST 2013 on pts/1
-sh-4.2$ passwd
Changing password for user tuser.
Current Password: 
Password change failed. Server message: Old password not accepted.
passwd: Authentication token manipulation error

Maybe in another patch we can amend pack_user_info_chpass_error() to not
require the last two parameters and just pass NULL, but that's not
required now.

ACK

[Jakub Hrozek]

On Sun, Aug 11, 2013 at 08:32:55PM +0200, Jakub Hrozek wrote:
> On Fri, Aug 09, 2013 at 09:44:06PM +0200, Michal Židek wrote:
> > During password change operation if wrong current password was given
> > we gave no hint to the user about what went wrong. The "Authentication
> > token manipulation error" message alone was not very descriptive.
> >
> > resolves:
> > https://fedorahosted.org/sssd/ticket/2029
> >
> > Thanks
> > Michal
>
> Works fine:
>
> su - tuser
> Password: 
> Last login: Sun Aug 11 20:29:44 CEST 2013 on pts/1
> -sh-4.2$ passwd
> Changing password for user tuser.
> Current Password: 
> Password change failed. Server message: Old password not accepted.
> passwd: Authentication token manipulation error
>
> Maybe in another patch we can amend pack_user_info_chpass_error() to not
> require the last two parameters and just pass NULL, but that's not
> required now.
>
> ACK

Pushed to master and sssd-1-10.

Attached is a 1.9 backport that I'm going to push to sssd-1-9

[Michal Židek]

On 08/11/2013 09:22 PM, Jakub Hrozek wrote:
> On Sun, Aug 11, 2013 at 08:32:55PM +0200, Jakub Hrozek wrote:
> > On Fri, Aug 09, 2013 at 09:44:06PM +0200, Michal Židek wrote:
> > > During password change operation if wrong current password was given
> > > we gave no hint to the user about what went wrong. The "Authentication
> > > token manipulation error" message alone was not very descriptive.
> > >
> > > resolves:
> > > https://fedorahosted.org/sssd/ticket/2029
> > >
> > > Thanks
> > > Michal
> >
> > Works fine:
> >
> > su - tuser
> > Password:
> > Last login: Sun Aug 11 20:29:44 CEST 2013 on pts/1
> > -sh-4.2$ passwd
> > Changing password for user tuser.
> > Current Password:
> > Password change failed. Server message: Old password not accepted.
> > passwd: Authentication token manipulation error
> >
> > Maybe in another patch we can amend pack_user_info_chpass_error() to not
> > require the last two parameters and just pass NULL, but that's not
> > required now.
> >
> > ACK
>
> Pushed to master and sssd-1-10.
>
> Attached is a 1.9 backport that I'm going to push to sssd-1-9

Tested with chpass providers ipa and ldap. Works fine in 1.9.

ACK

[Jakub Hrozek]

On Sun, Aug 11, 2013 at 10:24:42PM +0200, Michal Židek wrote:
> On 08/11/2013 09:22 PM, Jakub Hrozek wrote:
> > On Sun, Aug 11, 2013 at 08:32:55PM +0200, Jakub Hrozek wrote:
> > > On Fri, Aug 09, 2013 at 09:44:06PM +0200, Michal Židek wrote:
> > > > During password change operation if wrong current password was given
> > > > we gave no hint to the user about what went wrong. The "Authentication
> > > > token manipulation error" message alone was not very descriptive.
> > > >
> > > > resolves:
> > > > https://fedorahosted.org/sssd/ticket/2029
> > > >
> > > > Thanks
> > > > Michal
> > >
> > > Works fine:
> > >
> > > su - tuser
> > > Password:
> > > Last login: Sun Aug 11 20:29:44 CEST 2013 on pts/1
> > > -sh-4.2$ passwd
> > > Changing password for user tuser.
> > > Current Password:
> > > Password change failed. Server message: Old password not accepted.
> > > passwd: Authentication token manipulation error
> > >
> > > Maybe in another patch we can amend pack_user_info_chpass_error() to not
> > > require the last two parameters and just pass NULL, but that's not
> > > required now.
> > >
> > > ACK
> >
> > Pushed to master and sssd-1-10.
> >
> > Attached is a 1.9 backport that I'm going to push to sssd-1-9
>
> Tested with chpass providers ipa and ldap. Works fine in 1.9.
>
> ACK

Thank you for the review, pushed to sssd-1-9