[sssd PR#1007][opened] LDAP: Remove unused sdap_refresh code

[elkoniu]

URL: https://github.com/SSSD/sssd/pull/1007
Author: elkoniu
 Title: #1007: LDAP: Remove unused sdap_refresh code
Action: opened

PR body:
"""
There was a refactoring of LDAP background refresh task
in the middle of 2019 made by Jan Hrozek and Summit Bose.
Now LDAP refresh is done by generic be_refresh.
SDAP refresh functions are unused anymore.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1007/head:pr1007
git checkout pr1007

[sssd PR#1007][comment] LDAP: Remove unused sdap_refresh code

[elkoniu]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: LDAP: Remove unused sdap_refresh code

elkoniu commented:
"""
I just need to check one thing - if similar functions for AD and IPA are unused too.
@jhrozek if those functions will be unused should I remove them in this PR or make new one?
"""

See the full comment at https://github.com/SSSD/sssd/pull/1007#issuecomment-601172020

[sssd PR#1007][comment] LDAP: Remove unused sdap_refresh code

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: LDAP: Remove unused sdap_refresh code

jhrozek commented:
"""
On Thu, Mar 19, 2020 at 06:17:27AM -0700, Paweł Poławski wrote:
> I just need to check one thing - if similar functions for AD and IPA are unused too.
> @jhrozek if those functions will be unused should I remove them in this PR or make new one?

Up to you..

"""

See the full comment at https://github.com/SSSD/sssd/pull/1007#issuecomment-601193717

[sssd PR#1007][+Accepted] LDAP: Remove unused sdap_refresh code

[mzidek-gh]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: LDAP: Remove unused sdap_refresh code

Label: +Accepted

[sssd PR#1007][+Changes requested] LDAP: Remove unused sdap_refresh code

[mzidek-gh]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: LDAP: Remove unused sdap_refresh code

Label: +Changes requested

[sssd PR#1007][-Accepted] LDAP: Remove unused sdap_refresh code

[mzidek-gh]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: LDAP: Remove unused sdap_refresh code

Label: -Accepted

[sssd PR#1007][comment] LDAP: Remove unused sdap_refresh code

[mzidek-gh]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: LDAP: Remove unused sdap_refresh code

mzidek-gh commented:
"""
Actually changing to changes requested until the name is fixed :) But maybe it can be fixed before pushing by the legacy Pavel :)
"""

See the full comment at https://github.com/SSSD/sssd/pull/1007#issuecomment-603167259

[sssd PR#1007][edited] [WIP] LDAP: Remove unused sdap_refresh code

[elkoniu]

URL: https://github.com/SSSD/sssd/pull/1007
Author: elkoniu
 Title: #1007: [WIP] LDAP: Remove unused sdap_refresh code
Action: edited

Changed field: title
Original value:
"""
LDAP: Remove unused sdap_refresh code
"""

[sssd PR#1007][comment] [WIP] LDAP: Remove unused sdap_refresh code

[elkoniu]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: [WIP] LDAP: Remove unused sdap_refresh code

elkoniu commented:
"""
@mzidek-gh Sorry for name mistype in commit message, I did not noticed it:)

After some testing this code cant be removed. It is still in use but way of calling it changed and this is the reason why it looks to be unused.

What is the right way to close this PR without merge? Should I close it myself?
"""

See the full comment at https://github.com/SSSD/sssd/pull/1007#issuecomment-604158538

[sssd PR#1007][comment] [WIP] LDAP: Remove unused sdap_refresh code

[elkoniu]

URL: https://github.com/SSSD/sssd/pull/1007
Title: #1007: [WIP] LDAP: Remove unused sdap_refresh code

elkoniu commented:
"""
Looks like the right way is to close it by myself as I created it.
"""

See the full comment at https://github.com/SSSD/sssd/pull/1007#issuecomment-604349130

[sssd PR#1007][closed] [WIP] LDAP: Remove unused sdap_refresh code

[elkoniu]

URL: https://github.com/SSSD/sssd/pull/1007
Author: elkoniu
 Title: #1007: [WIP] LDAP: Remove unused sdap_refresh code
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1007/head:pr1007
git checkout pr1007