URL: https://github.com/SSSD/sssd/pull/527 Author: mzidek-rh Title: #527: PEP8 Fixes and enable PEP8 check in CI Action: opened
PR body: """ Hi,
because @fidencio is on PTO I allowed myself to rebase and update his branch: https://github.com/fidencio/sssd/tree/wip/ci_enable_pep8_check
and present it here as new PR.
Here is link to the ticket: https://pagure.io/SSSD/sssd/issue/3605
What I did: - reviewed all the patches that were not reviewed yet (some were already reviewed) - rebased them on top of current master (there were only minor conflicts) - if there are some missing patches that is because the issue that they fixed was no longer present in the current master, so I deleted them - added "Resolves" and "Reviewed" tags (so the person that pushes it does not need to add them) - pushed the patchset to CI (passed) - added pep8 issue and tried the CI (issue was detected on all platforms)
The patchest is now fully ACKed.
Note: because of the way I rebased the patches, some are not in the original order """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/527/head:pr527 git checkout pr527
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI
lslebodn commented: """ @mzidek-rh, Could you help me to find a way how to enable catching warning in commit "TESTS: Fix E501 pep8 issues on utils.py"?
``` sh-4.4$ git rev-parse --verify HEAD 47362caf4c30c3ff5a143f4f4a7fd5599db03b48 sh-4.4$ pep8 --version 1.6.2 sh-4.4$ pep8 src/tests/python/sssd/testlib/common/utils.py sh-4.4$ pep8 --max-line-length=79 src/tests/python/sssd/testlib/common/utils.py sh-4.4$ pep8 --max-line-length=79 --select=E501 src/tests/python/sssd/testlib/common/utils.py sh-4.4$ pep8 --ignore=E121,E123,E126,E226,E24,E704,W503,E722 src/tests/python/sssd/testlib/common/utils.py ```
It is also not reproducible with older and newer version (also tested with 1.5.7, 1.7.1 and 2.3.1) Maybe it is reproducible with older version of pep8. But it would be good to see that working on recent systems. BTW patch is correct and it is obvious after checking the file with editor. """
See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-370039380
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI
lslebodn commented: """ I would like to also ask whether it make a sense fix pep8 issues in the file src/tests/python-test.py. The file/test will be removed as part of PR #430. Fortunately, there is already a way how skip checking of pep8 errors in ci script.
BTW I tried really hard but I was not able to have "green" results from the test. (I manually create sssd.conf for local provider, install required dependencies python2-sss, python3-sss, sssd-tools, nscd, ldb-tools)
@mzidek-rh, or could you five me a tips how did you ensure that it still works? """
See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-370041624
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI
fidencio commented: """ @lslebodn, please, I would like to politely ask you to stop picking on PRs I have worked on.
While you were part of the team you deliberately blocked, not reviewed and delayed work that I have done. Now that you're not part of the team anymore I would like to ask you to drop the bone, let it go.
Thanks a lot for your understanding and have fun on your new role! """
See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-370341013
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI
fidencio commented: """ @lslebodn, hopefully at some point you'll understand that your opinion is not always the right one, that respecting your peers' opinions is also something valuable and that whoever disagrees with you is not automatically wrong.
Anyways, thanks a lot for your input. """
See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-370952909
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI
jhrozek commented: """ * master: 89f5332ccf59672ecafc36abe07d2351e32a05d5 a907aa07340ef0051cd74bbab9618820e1bca1b8 38cec21168b3b80c312e9efcfea4eba22a9648c8 1129979bf8a96e4a8389d8c997bc2437e9e7e328 40fab0e80857198605b69e1010ab5e090769cc99 942edc402f4acc3de4dc3ec15a89d31d9f206cf6 6df8895947fbd0a01df92b82d6f418c8202595b2 e27a07b94b1ec2e7d61b8fce388add6e3481f131 c13c7dd58ebe24fb07227f29008a7b6895f8d57b a7acb83aa5c70547f5575cdbb13228f23e3621c0 4c3ddbb119c1ca0e12c49f58b914559e2510e2f1 00f267a32a8d1c32c817eba4223c7c6d5a9d82da 01012f0d7799008e66a2d7109b7940146dcaf68d 25e0e4b0994e59e26d4144152f564b47ec84c8ea 87fe92e90c73c7b314e5c01fde623e87a37fc9d2 235917c1758a4dcaa859394325bb742048c46205 8e00bbcab18b2a33437cd430607f928e32b1fdf7 9dc4c15552c396a80add39d0da865793e5643237 7b9c3e69e5248940accc5e0c2ce08503bea87c75 f64f99dd56596ca25ee41e6e36ecbf8a6fd5b49e 629563edc4538aaf6f55c229c82bd4041d8122c7 8b53952cbc3bf0ec84804e6be0a9b1256a49c19f 4593a2f126c83c4d05f942da7df59b2cc656cf20 0e16e020bf73022adf6b6470b95ae8ee72004036 5e86d31f9b151a34cdb9df76349a083f9632fc10 e3f0de237540024cbe3b14385342c7cbf991d001 01e7730dabb7971e605b72fe66f936f15a84ffa6 71dc7aa5c1c838ce85372071905f045d400e6fad 3fac321c1580f64ec5412c49a997d2a14bfe1052 018fe983c8eee68c4acb5e5fba1675f3119ded17 b4d72adc14e7ca110a97b76caff682fdcee617be f02b0bddd8004ddd04cd852b24d3d8a3aa3191e6 b4c08cb3249cd270e38e9b74a83c00c38ec16c19 16fe3a34960ff3a5c79c6412b755220545501968 da694601229b5c8c5303a91317f067a912599e89 """
See the full comment at https://github.com/SSSD/sssd/pull/527#issuecomment-372056790
URL: https://github.com/SSSD/sssd/pull/527 Author: mzidek-rh Title: #527: PEP8 Fixes and enable PEP8 check in CI Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/527/head:pr527 git checkout pr527
URL: https://github.com/SSSD/sssd/pull/527 Title: #527: PEP8 Fixes and enable PEP8 check in CI
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek
-
lslebodn
-
mzidek-rh