[PATCH] Potential NULL-dereference in sudosrv_cmd_get_sudorules

[Pavel Březina]

https://fedorahosted.org/sssd/ticket/1236

[Jakub Hrozek]

On Fri, Mar 09, 2012 at 02:02:03PM +0100, Pavel Březina wrote:
> https://fedorahosted.org/sssd/ticket/1236

There are still two cases above the one you fixed that "goto done"
before dctx is allocated. I also think you should return after calling
sudosrv_cmd_send_error().

[Pavel Březina]

On 03/09/2012 02:11 PM, Jakub Hrozek wrote:
> On Fri, Mar 09, 2012 at 02:02:03PM +0100, Pavel Březina wrote:
> > https://fedorahosted.org/sssd/ticket/1236
>
> There are still two cases above the one you fixed that "goto done"
> before dctx is allocated. I also think you should return after calling
> sudosrv_cmd_send_error().

Ooops, thank you.

[Jakub Hrozek]

On Fri, Mar 09, 2012 at 02:50:59PM +0100, Pavel Březina wrote:
> On 03/09/2012 02:11 PM, Jakub Hrozek wrote:
> > On Fri, Mar 09, 2012 at 02:02:03PM +0100, Pavel Březina wrote:
> > > https://fedorahosted.org/sssd/ticket/1236
> >
> > There are still two cases above the one you fixed that "goto done"
> > before dctx is allocated. I also think you should return after calling
> > sudosrv_cmd_send_error().
>
> Ooops, thank you.

Ack

[Stephen Gallagher]

On Fri, 2012-03-09 at 16:10 +0100, Jakub Hrozek wrote:
> On Fri, Mar 09, 2012 at 02:50:59PM +0100, Pavel Březina wrote:
> > On 03/09/2012 02:11 PM, Jakub Hrozek wrote:
> > > On Fri, Mar 09, 2012 at 02:02:03PM +0100, Pavel Březina wrote:
> > > > https://fedorahosted.org/sssd/ticket/1236
> > >
> > > There are still two cases above the one you fixed that "goto done"
> > > before dctx is allocated. I also think you should return after calling
> > > sudosrv_cmd_send_error().
> >
> > Ooops, thank you.
>
> Ack

Pushed to master and sssd-1-8.