[sssd PR#377][opened] This patch set fixes a bunch RHEL6 warnings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch RHEL6 warnings
Action: opened

PR body:
"""
Those patches were part of PR#50, which got stuck for a long time and ended up closed as
it didn't seem interesting for the project.

However, after some time another PR (PR#371) fixes the very same issues. So, I'd like
to have my patches (at least) considered and, if possible, reviewed.

In any case, this PR is basically PR#50 without the patch that makes use of gnulib many
warnings.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377

[sssd PR#377][synchronized] This patch set fixes a bunch RHEL6 warnings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch RHEL6 warnings
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377

[sssd PR#377][synchronized] This patch set fixes a bunch RHEL6 warnings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch RHEL6 warnings
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377

[sssd PR#377][edited] This patch set fixes a bunch warnings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch warnings
Action: edited

 Changed field: title
Original value:
"""
This patch set fixes a bunch RHEL6 warnings
"""

[sssd PR#377][comment] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

fidencio commented:
"""
retest this, please
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-328276064

[sssd PR#377][comment] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

lslebodn commented:
"""
There are some patches with initialize some variables to NULL, 0 .. on rhle6
I assume they are caused by old gcc in e6 + combination with `-O1`. I was enabled due to
coverage bug in el6 057f699b401097ad7f48fe3760e81c6993619a4b. I would prefer to drop
them

I'm fine with suppressing warnings on el6 with `-02`

 
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-329103484

[sssd PR#377][+Changes requested] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

Label: +Changes requested

[sssd PR#377][comment] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

lslebodn commented:
"""
Thank you for reviving this patchset with fixed warnings
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-329103687

[sssd PR#377][comment] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

fidencio commented:
"""
@lslebodn, for some reason when I reset the patchset I didn't have the latest version
of the patches :-/

Okay, now I have it and will re-work according to your comments.
May I add your patches in PR #371 here as well? (of course, keeping your authorship)
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-329130623

[sssd PR#377][synchronized] This patch set fixes a bunch warnings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch warnings
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377

[sssd PR#377][comment] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

fidencio commented:
"""
I have updated the patch set, now using the correct version of the patches done for PR
#50. Also, I have added to this PR one patch from PR #371 that was not part of PR #50.

IMHO, PR #371 should be closed and this one should be reviewed instead.
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-330207459

[sssd PR#377][-Changes requested] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

Label: -Changes requested

[sssd PR#377][+Changes requested] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

Label: +Changes requested

[sssd PR#377][synchronized] This patch set fixes a bunch warnings

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch warnings
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377

[sssd PR#377][-Changes requested] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

Label: -Changes requested

[sssd PR#377][comment] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

fidencio commented:
"""
Patch set has been updated addressing @lslebodn's comments.

Thanks for the review.
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-331871694

[sssd PR#377][comment] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

lslebodn commented:
"""
On (25/09/17 12:54), fidencio wrote:
> fidencio commented on this pull request.
>
>
>
> > @@ -195,7 +195,15 @@ struct sdap_get_initgr_state *prepare_state(struct
> test_sdap_initgr_ctx *ctx,
>      }
>      assert_non_null(state->dom);
>      assert_non_null(recent_dom_info);
> -    recent_dom_info->next = NULL;
>
> Okay, this patch has been dropped from this PR.
>  
Do you have an idea why you can see such warning?
but others cannot

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-331874976

[sssd PR#377][comment] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

lslebodn commented:
"""
ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-331876520

[sssd PR#377][+Accepted] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

Label: +Accepted

[sssd PR#377][comment] This patch set fixes a bunch warnings

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

fidencio commented:
"""
@lslebodn, IIRC I saw that in our CI but not on my system.

So, in case I face it again, I'll add it as part of the PR #378.
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-331877062

[sssd PR#377][comment] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

lslebodn commented:
"""
retest this please
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-331935988

[sssd PR#377][comment] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

lslebodn commented:
"""
master:
* 39e300314cb43e534179a6950274e1e9c9a48465
* d8d49ae91708a2360c5c8f7a01e531952e2f7771
* 01f852fcb27e0a0a07e2b8b51e7e838a256b485f
* 3cb4592e27dac8032bd528b6a9f1b49dfa4ec0b8
* 1ef1056e73e306eb042c4d58f9cfaee621a5cbbe
* 47863dee64fa93859bc16ddc387010734da665ee
* 76ff0b1dd08b4f7320daa2d63ed4f052757b8ddf
* 1a9cdc6ba3d1f9101d84992f6e37e8739e6a9d7c
* 0e6248c60791ccfe840a2938f27b56b9e72370e3
* f194bd0fa75f87ac29dc08c3aeca9aa86311bfc5
* 58a9b4f0b195f6ea1271d24990bf4df04eccd6ed
"""

See the full comment at https://github.com/SSSD/sssd/pull/377#issuecomment-331989094

[sssd PR#377][closed] This patch set fixes a bunch warnings

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/377
Author: fidencio
 Title: #377: This patch set fixes a bunch warnings
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/377/head:pr377
git checkout pr377

[sssd PR#377][+Pushed] This patch set fixes a bunch warnings

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/377
Title: #377: This patch set fixes a bunch warnings

Label: +Pushed