On Tue, Sep 03, 2013 at 09:01:57PM +0200, Jakub Hrozek wrote:
On Tue, Sep 03, 2013 at 08:54:39PM +0200, Jakub Hrozek wrote:
> On Tue, Sep 03, 2013 at 01:47:59PM +0200, Lukas Slebodnik wrote:
> > On (03/09/13 13:34), Jakub Hrozek wrote:
> > >On Tue, Sep 03, 2013 at 01:09:55PM +0200, Sumit Bose wrote:
> > >> On Mon, Sep 02, 2013 at 06:25:50PM +0200, Lukas Slebodnik wrote:
> > >> > On (02/09/13 17:50), Sumit Bose wrote:
> > >> > >On Mon, Sep 02, 2013 at 05:43:06PM +0200, Lukas Slebodnik
wrote:
> > >> > >> ehlo,
> > >> > >>
> > >> > >> I tested some patches on RHEL6. and there is newly
introduced warning.
> > >> > >> gcc version 4.4.7
> > >> > >>
> > >> > >> src/providers/krb5/krb5_utils.c:193: warning:
declaration of 'rewind' shadows a
> > >> > >> global declaration
> > >> > >> /usr/include/stdio.h:754: warning: shadowed declaration
is here
> > >> > >>
> > >> > >> Warning was introduced in patch
dcc6877aa2e2dd63a9dc9c411a9c58feaeb36b9a
> > >> > >> "krb5: Fetch ccname template from krb5.conf"
> > >> > >>
> > >> > >> LS
> > >> > >
> > >> > >ACK. I was about to send the same patch, just with a
different name :-)
> > >> > >
> > >> > >bye,
> > >> > >Sumit
> > >> > I renamed "rewind" -> "want_rewind"
> > >> > What was your proposal? Maybe your will be better.
> > >>
> > >> I used 'rerun' the name of the little brother of Linus (van
Pelt not
> > >> Torvalds :-)
> > >>
> > >> bye,
> > >> Sumit
> > >
> > >I like the shorter name better.
> >
> > This was a reason why I asked.
> >
> > Attached patch contains "shorter version"
> >
> > LS
>
> ACK
Pushed to master.
Also pushed to sssd-1-10