[sssd PR#100][opened] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
6:13 a.m.
URL: https://github.com/SSSD/sssd/pull/100
Author: amitkumar50
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Action: opened
PR body:
"""
https://fedorahosted.org/sssd/ticket/2201
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/100/head:pr100
git checkout pr100
6:13 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-264158741
6:13 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-264158745
6:07 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
amitkumar50 commented:
"""
Kindly review this Pull request..
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-264700095
2:28 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
pbrezina commented:
"""
ok to test
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-264793956
2:30 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
pbrezina commented:
"""
Hi, thank you for your contribution. I would personally use different phrasing: "Note
that the lowest values possible is 60 seconds." or similar. What do you think is
better? One nitpick, you are missing a space before "Note".
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-264794286
6:03 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
lslebodn commented:
"""
On (04/12/16 04:07), amitkumar50 wrote:
Kindly review this Pull request..
It would be good if you could keep all changes in one pull request.
Creating more pull request for the same is not very common use case.
FYI: It shoudl be enought to force push to previous branch
in your github repo.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-264837807
12:48 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
amitkumar50 commented:
"""
Hi,
Thanks for valuable comment.
I am planning to use this:
Note that lowest possible value is 60 seconds in-case if value is provided less than 60,
parameter will assume lowest value only.
Thanks
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-265074549
2:59 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
pbrezina commented:
"""
It sounds good to me. Thank you for your contribution. I will leave final ack for some
native speaker.
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-265392154
11:14 p.m.
New subject: [sssd PR#100][synchronized] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Author: amitkumar50
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/100/head:pr100
git checkout pr100
11:42 p.m.
New subject: [sssd PR#100][synchronized] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Author: amitkumar50
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/100/head:pr100
git checkout pr100
9:28 a.m.
New subject: [sssd PR#100][synchronized] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
Hello,
kindly review https://github.com/SSSD/sssd/pull/100
commit f8f208f6f1a12e25d46b80459d87ae269924117d
Thanks
On 12/08/2016 11:12 AM, amitkumar50 wrote:
URL: https://github.com/SSSD/sssd/pull/100
Author: amitkumar50
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/100/head:pr100
git checkout pr100
_______________________________________________
sssd-devel mailing list -- sssd-devel(a)lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-leave(a)lists.fedorahosted.org
6:18 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
amitkumar50 commented:
"""
Kindly review this recent Pull request.. commit f8f208f6f1a12e25d46b80459d87ae269924117d
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-265727165
6:03 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
pbrezina commented:
"""
Hi, ack to the content. I have only one nitpick from the technical point of view, can you
please squash those patches together? See:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html how to squash
the patches.
@justin-stephenson do you have some language comments? Thank you.
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-266415117
8:51 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
justin-stephenson commented:
"""
Okay from my perspective.
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-266449797
3:51 a.m.
New subject: [sssd PR#100][+Accepted] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Label: +Accepted
6:06 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
jhrozek commented:
"""
Actually, I didn't notice at first the patches are still split into three. if you
squash the patches, I'll push them.
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-267017891
6:06 a.m.
New subject: [sssd PR#100][+Changes requested] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Label: +Changes requested
6:06 a.m.
New subject: [sssd PR#100][-Accepted] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Label: -Accepted
7:36 p.m.
New subject: [sssd PR#100][synchronized] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Author: amitkumar50
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/100/head:pr100
git checkout pr100
4:19 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
lslebodn commented:
"""
@amitkumar50 Could you squash the patches to the single patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-270873989
4:40 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
lslebodn commented:
"""
Ups; I didn't notice that it's already done ACK++
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-270877830
4:50 a.m.
New subject: [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
lslebodn commented:
"""
master:
* dfbbe39f49ba3f7ff64370fecef971f091214d47
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-270879641
4:52 a.m.
New subject: [sssd PR#100][+Pushed] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Label: +Pushed
4:52 a.m.
New subject: [sssd PR#100][-Changes requested] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Label: -Changes requested
4:52 a.m.
New subject: [sssd PR#100][closed] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds
URL: https://github.com/SSSD/sssd/pull/100
Author: amitkumar50
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60
seconds
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/100/head:pr100
git checkout pr100
2666
days inactive
2702
days old
sssd-devel@lists.fedorahosted.org
25 comments
2 participants
participants (2)
-
amit kumar -
fidencio