[PATCH 1/2] Remove append_attrs_to_array This used to be part of the deref patchset. Since the function is not used, I think it should be removed.
[PATCH 2/2] Rename label in expand_ccname_template Simo had a comment about one of my previous patches, but came too late :-) This patch fixes the label name so it is clear that it is hit even on success.
Jakub Hrozek jhrozek@redhat.com wrote:
[PATCH 1/2] Remove append_attrs_to_array This used to be part of the deref patchset. Since the function is not used, I think it should be removed.
Sounds reasonable. Even in the patch itself I couldn't find any place where this function is called which makes me wonder why it was there in the first place. I couldn't find any comment on mailing list, so if Stephen has no objections I give Ack.
[PATCH 2/2] Rename label in expand_ccname_template Simo had a comment about one of my previous patches, but came too late
:-) This patch fixes the label name so it is clear that it is hit even
on success.
Ack
Jan
On Wed, 2011-05-18 at 20:40 +0200, Jan Zeleny wrote:
Jakub Hrozek jhrozek@redhat.com wrote:
[PATCH 1/2] Remove append_attrs_to_array This used to be part of the deref patchset. Since the function is not used, I think it should be removed.
Sounds reasonable. Even in the patch itself I couldn't find any place where this function is called which makes me wonder why it was there in the first place. I couldn't find any comment on mailing list, so if Stephen has no objections I give Ack.
[PATCH 2/2] Rename label in expand_ccname_template Simo had a comment about one of my previous patches, but came too late
:-) This patch fixes the label name so it is clear that it is hit even
on success.
Ack
Pushed to master
sssd-devel@lists.fedorahosted.org