URL: https://github.com/SSSD/sssd/pull/5684 Author: kkang-wr Title: #5684: src/conf_macros.m4: set default value /run for pidpath Action: opened
PR body: """ /var/run is deprecated, so replace /var/run with /run as the default value of variable pidpath.
Signed-off-by: Kai Kang kai.kang@windriver.com """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5684/head:pr5684 git checkout pr5684
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
kkang-wr commented: """ Where can I see the detailed failure logs, please? """
See the full comment at https://github.com/SSSD/sssd/pull/5684#issuecomment-862003350
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
sumit-bose commented: """
Where can I see the detailed failure logs, please?
Hi,
the failures happen during the integration tests and can be seen in the `ci-make-intgcheck.log` log files. You can run the integration tests locally by calling `make intgcheck`, see https://sssd.io/contrib/tests/integration-tests.html for details.
I think the reason for the failure is that in the chroot environment used for the self-tests there is no `/run` directory created. Maybe adding a link to `/var/run` somewhere near https://github.com/SSSD/sssd/blob/master/Makefile.am#L4069 will help?
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5684#issuecomment-862181741
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
pbrezina commented: """ Hi, we have `runstatedir` that could be used here:
``` $ git grep runstatedir Makefile.am:runstatedir = @runstatedir@ Makefile.am: -DSSS_SEC_SOCKET_NAME="$(runstatedir)/secrets.socket" \ Makefile.am: -e 's|@runstatedir[@]|$(runstatedir)|g' \ contrib/sssd.spec.in:%make_build all docs runstatedir=%{_rundir} src/conf_macros.m4: if test x"$runstatedir" = x; then src/conf_macros.m4: AC_SUBST([runstatedir], src/sysv/systemd/sssd-kcm.socket.in:ListenStream=@runstatedir@/.heim_org.h5l.kcm-socket src/sysv/systemd/sssd-secrets.socket.in:ListenStream=@runstatedir@/secrets.socket src/tests/intg/Makefile.am: $(MKDIR_P) $(DESTDIR)$(runstatedir)/dbus src/tests/intg/Makefile.am: $(SED) -e "s!@runstatedir[@]!$(runstatedir)!" \ src/tests/intg/Makefile.am: -D "runstatedir=`$(runstatedir)'" \ src/tests/intg/Makefile.am: DBUS_SOCK_DIR="$(DESTDIR)$(runstatedir)/dbus/" \ src/tests/intg/config.py.m4:RUNSTATEDIR = "runstatedir" src/tests/intg/data/cwrap-dbus-system.conf.in: <pidfile>@runstatedir@/dbus/messagebus.pid</pidfile> src/tests/intg/data/cwrap-dbus-system.conf.in: <listen>unix:path=@runstatedir@/dbus/system_bus_socket</listen> ``` """
See the full comment at https://github.com/SSSD/sssd/pull/5684#issuecomment-863110532
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
kkang-wr commented: """ Hi @sumit-bose, @pbrezina, Thanks a lot for your informations.
The configure option '--with-pid-path=/run' works for me. I just thought that /var/run is deperated for most of popular linux distributions, so I send out the patch to see whether we need to do this change. If it is not necessary, please ignore it.
Regards, Kai """
See the full comment at https://github.com/SSSD/sssd/pull/5684#issuecomment-863667616
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
pbrezina commented: """ Hi, we certainly welcome your contribution. It just would be good to use a runstatedir which represents the /run directory but at the same time remains configurable instead of hardcoding the value again, if that is something you are willing to work on. """
See the full comment at https://github.com/SSSD/sssd/pull/5684#issuecomment-863887378
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath
alexey-tikhonov commented: """
Hi, we certainly welcome your contribution. It just would be good to use a runstatedir which represents the /run directory but at the same time remains configurable instead of hardcoding the value again, if that is something you are willing to work on.
Since there was no response, I will close this PR awhile. Please open a new one in case you are still interested to work on this. """
See the full comment at https://github.com/SSSD/sssd/pull/5684#issuecomment-934493704
URL: https://github.com/SSSD/sssd/pull/5684 Author: kkang-wr Title: #5684: src/conf_macros.m4: set default value /run for pidpath Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5684/head:pr5684 git checkout pr5684
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
kkang-wr
-
pbrezina
-
sumit-bose