URL: https://github.com/SSSD/sssd/pull/971 Author: scabrero Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN Action: opened
PR body: """ In systems where gethostbyname() does not return the FQDN try calling getaddrinfo().
The same happened to adcli, fixed by https://gitlab.freedesktop.org/sbose/adcli/commit/85b835f8258a57e3b23de47a25... """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/971/head:pr971 git checkout pr971
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
centos-ci commented: """ Can one of the admins verify this patch? """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-575680267
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
alexey-tikhonov commented: """ ok to test """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-575688783
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
sumit-bose commented: """ Hi @scabrero,
thanks for the patch. I think it makes sense, especially when used together with recent adcli.
But in theory this is a change in behavior and I wonder if there are setups which are carefully crafted so that with a short hostname everything works as expected? Although the used ad_hostname is already printed in the logs with level SSSDBG_CONF_SETTINGS, I think it is worth to add another message in case the short name is expanded which explains that ad_hostname should be set explicitly if SSSD should really use a short name.
bye, Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-576560761
URL: https://github.com/SSSD/sssd/pull/971 Author: scabrero Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/971/head:pr971 git checkout pr971
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
scabrero commented: """
But in theory this is a change in behavior and I wonder if there are setups which are carefully crafted so that with a short hostname everything works as expected?
I honestly do not know and maybe they exist, but what I found is that when the short hostname is used dynamic DNS updates break.
Although the used ad_hostname is already printed in the logs with level SSSDBG_CONF_SETTINGS, I think it is worth to add another message in case the short name is expanded which explains that ad_hostname should be set explicitly if SSSD should really use a short name.
Done, good idea. """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-576659648
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
scabrero commented: """
But in theory this is a change in behavior and I wonder if there are setups which are carefully crafted so that with a short hostname everything works as expected?
I honestly do not know and maybe they exist, but what I found is that when the short hostname is used dynamic DNS updates break.
Although the used ad_hostname is already printed in the logs with level SSSDBG_CONF_SETTINGS, I think it is worth to add another message in case the short name is expanded which explains that ad_hostname should be set explicitly if SSSD should really use a short name.
Done, good idea. """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-576659648
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
sumit-bose commented: """ Hi,
thanks for the update. Can you add a `\n` at the end of the debug message?
Finally, can you update the `ad_hostname` entry of the `sssd-ad` man page with the new behavior?
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-577651896
URL: https://github.com/SSSD/sssd/pull/971 Author: scabrero Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/971/head:pr971 git checkout pr971
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
sumit-bose commented: """ Thanks. ACK """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-577731495
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
sumit-bose commented: """ Hi @pbrezina, @mzidek-gh,
since this patch introduce a slight change in behavior it might be good to not include this in a 2.2.x version. So maybe it is time to branch of 2.2 and use master for 2.3?
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-578129581
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
alexey-tikhonov commented: """ Hi @sumit-bose,
since this patch introduce a slight change in behavior it might be good to not include this in a 2.2.x version.
What's actually wrong with keeping this in 2.2.x until it is not used for a rebase?
So maybe it is time to branch of 2.2 and use master for 2.3?
This way we will have to backport (important/most of) bugfixes to two branches... """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-578137816
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
pbrezina commented: """ Make sense to branch to 2.3. We don't need to backport patches to do another 2.2 release since it is not LTM and we pretty much said there won't be LTM release anymore. @mzidek-gh it's up to you. """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-578717051
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
alexey-tikhonov commented: """
We don't need to backport patches to do another 2.2 release since it is not LTM and we pretty much said there won't be LTM release anymore.
Then I see no reason to keep 2.2 as a branch at all. Would not it be enough to just bump version (and probably tag 2.2.x)?
"""
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-578721372
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
pbrezina commented: """ As discussed on last meeting, @mzidek-gh will bump the version and I will push these patches afterwards. """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-587430946
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
pbrezina commented: """ @mzidek-gh What is the status on bumping the version? """
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-590308554
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
pbrezina commented: """ * `master` * 2143c7276c7603520e2575ef6c9d93a5fc031256 - AD: use getaddrinfo with AI_CANONNAME to find the FQDN
"""
See the full comment at https://github.com/SSSD/sssd/pull/971#issuecomment-593329545
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/971 Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/971 Author: scabrero Title: #971: AD: use getaddrinfo with AI_CANONNAME to find the FQDN Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/971/head:pr971 git checkout pr971
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
centos-ci
-
pbrezina
-
scabrero
-
sumit-bose