[sssd PR#796][opened] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: opened

PR body:
"""
Fedora 28 is the latest version containing 1.16 so I think it is fine
to not run the test against Fedora 29+. Besides this change this patch
contains files from master without change.

(including PR 793 that is not yet merge)
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
I have no idea why `test_ipa_subdom_server` fails with `99`:
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-796/2/fedora28/test-suit...


"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-478038113

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

alexey-tikhonov commented:
"""
>  I have no idea why `test_ipa_subdom_server` fails with `99`:
> https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-796/2/fedora28/test-suit...
>  
99 means Valgrind error.

Would you please check if ca63dbb796ab6243ff6167af709d46e8b1939c4e helps?
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-478068755

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

alexey-tikhonov commented:
"""
>  I have no idea why `test_ipa_subdom_server` fails with `99`:
> https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-796/2/fedora28/test-suit...
>  
99 means Valgrind error.

I saw similar problem with the same test and I thought it was fixed in 1-16 by
ca63dbb796ab6243ff6167af709d46e8b1939c4e

Do you have detailed logs of failing test being run under Valgrind?
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-478068755

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
Thank you for the hint. It turned out that I did not rebase it on top of current sssd-1-16
so this patch was missing.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-478510287

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

jhrozek commented:
"""
Is it on purpose that only Fedora-28 is added for now? Since there is also PR #793 would
it make sense to also add the newer distributions here? (I can ack that PR first if you
prefer to have all distros added to master first and then to sssd-1-16)
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-479842874

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
It is on purpose. The reason is in the pull request description: Fedora 28 is the latest
version that contains SSSD 1.16.  Fedora 29+ contains SSSD 2.0, thus I do not think it is
necessary to run 1.16 test on those distros. But if you think it is meaningful, it is easy
to add it here as well.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-479853165

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

jhrozek commented:
"""
I'm sorry I dropped PR reviews lately. I think it would be nice to add also the modern
distributions. As upstream, we should make sure our stable branch runs even on more modern
systems.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-488079316

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
Ok. I added rest of the distros that are currently available.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-488619010

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

jhrozek commented:
"""
OK, after some delay, I'm trying to get back to upstream reviews..

Do you know why these would fail? How can I re-run the CI runs?
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-494126340

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
The job was aborted because a timeout occurs. Unfortunately the pipeline logs do not
provide much information so I'm not sure what timeout was hit. I will learn more about
timeouts in Jenkins. But I think these patches can be pushed in the mean time.

I rescheduled the job. You can reschedule it from the Jenkins instance.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-494266098

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
@jhrozek KCM integration tests fails for fedora > 28, see:
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-796/6/fedora30/ci-make-i... Is
this something that is expected and should be fixed on distribution level (like some
package missing)?
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-494299129

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

jhrozek commented:
"""
Not expected. I don't know what it is, all the tests with the secrets responder are
failing, but not with the secdb.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-494306139

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

pbrezina commented:
"""
I updated the patches with the timeout fix from master.
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-504324074

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][synchronized] ci: enable sssd-ci for 1-16 branch

[pbrezina]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

jhrozek commented:
"""
One of the intgchecks failed in centos CI but that's really irrelevat to this patch,
so ack
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-511852678

[sssd PR#796][+Accepted] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

Label: +Accepted

[sssd PR#796][comment] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

jhrozek commented:
"""
* sssd-1-16:
 * 85dab318ce0ea745722a89a761d60bb33b102f6f
 * 8003e324912741c3083147180d7ee5fb0827eb0a
 * f988c870b2a8daa049896da1c8cd462b0ca173b4
 * 23ad178aa90e964fdf51b798e384958225398cf2
"""

See the full comment at https://github.com/SSSD/sssd/pull/796#issuecomment-511865344

[sssd PR#796][closed] ci: enable sssd-ci for 1-16 branch

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/796
Author: pbrezina
 Title: #796: ci: enable sssd-ci for 1-16 branch
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/796/head:pr796
git checkout pr796

[sssd PR#796][+Pushed] ci: enable sssd-ci for 1-16 branch

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch

Label: +Pushed