[PATCH] FO: Check server validity before setting status

[Jakub Hrozek]

Please see the attached patch. This is more of a band-aid, but the
correct solution would be much more involved and is being tracked by
#1522.

[Michal Židek]

On 09/12/2012 07:50 PM, Jakub Hrozek wrote:
> Please see the attached patch. This is more of a band-aid, but the
> correct solution would be much more involved and is being tracked by
> #1522.
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

ACK to the patch. This definitely minimizes the probability of
bad race condition scenario, but as Jakub mentioned, the
problem is not definitely solved and might occur if the 
be_fo_set_port_status function finishes the check and is
interrupted by some async request before fo_set_port_status
was called (and succesfully finished).

However, this is the best thing we have so far.

Michal

[Pavel Březina]

On 09/12/2012 07:50 PM, Jakub Hrozek wrote:
> Please see the attached patch. This is more of a band-aid, but the
> correct solution would be much more involved and is being tracked by
> #1522.

Ack. Great job catching this!

[Jakub Hrozek]

On Thu, Sep 13, 2012 at 01:20:58PM +0200, Pavel Březina wrote:
> On 09/12/2012 07:50 PM, Jakub Hrozek wrote:
> > Please see the attached patch. This is more of a band-aid, but the
> > correct solution would be much more involved and is being tracked by
> > #1522.
>
> Ack. Great job catching this!

Pushed to master

[Jakub Hrozek]

On Thu, Sep 13, 2012 at 05:04:28PM +0200, Jakub Hrozek wrote:
> On Thu, Sep 13, 2012 at 01:20:58PM +0200, Pavel Březina wrote:
> > On 09/12/2012 07:50 PM, Jakub Hrozek wrote:
> > > Please see the attached patch. This is more of a band-aid, but the
> > > correct solution would be much more involved and is being tracked by
> > > #1522.
> >
> > Ack. Great job catching this!
>
> Pushed to master

Also pushed to sssd-1-8