On Thu, 2011-06-16 at 23:32 +0200, Jakub Hrozek wrote:
On 06/16/2011 06:29 PM, Stephen Gallagher wrote:
> On Thu, 2011-06-16 at 17:45 +0200, Jakub Hrozek wrote:
>> In c-ares 1.7, the upstream renamed the addrttl/addr6ttl structures to
>> ares_addrttl/ares_addr6ttl so they are in the ares_ namespace.
>>
>> Because they are committed to stable ABI, the contents are the same,
>> just the name changed -- so it is safe to just #define the new name for
>> older c-ares version.
>
> Is it possible to make this:
> #ifndef ares_addrttl
> #define ares_addrttl addrttl
> #endif
>
> I'd prefer not to forcibly #define those in case sometime in the future
> they opt to drop the old ABI.
>
Right, that is safer. New patch that explicitly checks for presence of
the structures is attached.
Ack and pushed to master.