[PATCH] IDMAP: Man change for ldap_idmap_range_size option

[Pavel Reichl]

Hello,

please see simple patch attached.

Thanks.

[Michal Židek]

On 01/28/2016 11:06 AM, Pavel Reichl wrote:
> Hello,
>
> please see simple patch attached.
>
> Thanks.

Hi,

The man page change looks good to me.

Sumit, IIRC you noticed the wrong man page info originally. Was there
also something else you wanted to change about idmap in man page or
is this all?

Michal

[Sumit Bose]

On Wed, Feb 03, 2016 at 01:49:30PM +0100, Michal Židek wrote:
> On 01/28/2016 11:06 AM, Pavel Reichl wrote:
> > Hello,
> >
> > please see simple patch attached.
> >
> > Thanks.
>
> Hi,
>
> The man page change looks good to me.
>
> Sumit, IIRC you noticed the wrong man page info originally. Was there
> also something else you wanted to change about idmap in man page or
> is this all?

No, my main concern was the upper limit of the range.

bye,
Sumit

[Michal Židek]

On 02/03/2016 02:11 PM, Sumit Bose wrote:
> On Wed, Feb 03, 2016 at 01:49:30PM +0100, Michal Židek wrote:
> > On 01/28/2016 11:06 AM, Pavel Reichl wrote:
> > > Hello,
> > >
> > > please see simple patch attached.
> > >
> > > Thanks.
> >
> > Hi,
> >
> > The man page change looks good to me.
> >
> > Sumit, IIRC you noticed the wrong man page info originally. Was there
> > also something else you wanted to change about idmap in man page or
> > is this all?
>
> No, my main concern was the upper limit of the range.
>
> bye,
> Sumit

Thanks Sumit!

I checked if the change corresponds to the
code behavior and it does. So ACK for that.

But we need native English speaker to ACK
the wording.

Michal

[Michal Židek]

On 02/03/2016 02:22 PM, Michal Židek wrote:
> On 02/03/2016 02:11 PM, Sumit Bose wrote:
> > On Wed, Feb 03, 2016 at 01:49:30PM +0100, Michal Židek wrote:
> > > On 01/28/2016 11:06 AM, Pavel Reichl wrote:
> > > > Hello,
> > > >
> > > > please see simple patch attached.
> > > >
> > > > Thanks.
> > >
> > > Hi,
> > >
> > > The man page change looks good to me.
> > >
> > > Sumit, IIRC you noticed the wrong man page info originally. Was there
> > > also something else you wanted to change about idmap in man page or
> > > is this all?
> >
> > No, my main concern was the upper limit of the range.
> >
> > bye,
> > Sumit
>
> Thanks Sumit!
>
> I checked if the change corresponds to the
> code behavior and it does. So ACK for that.
>
> But we need native English speaker to ACK
> the wording.
>
> Michal

Ok, Nathaniel approved the wording offline, so it is
a full ACK.

Michal

[Lukas Slebodnik]

On (03/02/16 14:34), Michal Židek wrote:
> On 02/03/2016 02:22 PM, Michal Židek wrote:
> > On 02/03/2016 02:11 PM, Sumit Bose wrote:
> > > On Wed, Feb 03, 2016 at 01:49:30PM +0100, Michal Židek wrote:
> > > > On 01/28/2016 11:06 AM, Pavel Reichl wrote:
> > > > > Hello,
> > > > >
> > > > > please see simple patch attached.
> > > > >
> > > > > Thanks.
> > > >
> > > > Hi,
> > > >
> > > > The man page change looks good to me.
> > > >
> > > > Sumit, IIRC you noticed the wrong man page info originally. Was there
> > > > also something else you wanted to change about idmap in man page or
> > > > is this all?
> > >
> > > No, my main concern was the upper limit of the range.
> > >
> > > bye,
> > > Sumit
> >
> > Thanks Sumit!
> >
> > I checked if the change corresponds to the
> > code behavior and it does. So ACK for that.
> >
> > But we need native English speaker to ACK
> > the wording.
> >
> > Michal
>
> Ok, Nathaniel approved the wording offline, so it is
> a full ACK.

master:
* d9de4b26f44a344025bbfa23104b7b67935fae35

sssd-1-13:
* c2fa17edf4b9d385302ddd24ce599a1cef7250a6

LS