[PATCH] MAN: Clarify the new krb5_use_fast IPA default

[Jakub Hrozek]

Hi,

while crafting the 1.11.4 release notes I realized that the new
krb5_use_fast IPA default was not reflected in the man page. This patch
fixes this omission.

[Simo Sorce]

On Mon, 2014-02-17 at 17:35 +0100, Jakub Hrozek wrote:
>  Hi,
>  
>  while crafting the 1.11.4 release notes I realized that the new
>  krb5_use_fast IPA default was not reflected in the man page. This patch
>  fixes this omission. 
Ack, to this patch.

Although maybe we should change in future and instead not the different
defaults in the respective sssd-ipa and sssd-ad mnapages ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Jakub Hrozek]

On Mon, Feb 17, 2014 at 11:59:29AM -0500, Simo Sorce wrote:
>  On Mon, 2014-02-17 at 17:35 +0100, Jakub Hrozek wrote:
>  > Hi,
>  > 
>  > while crafting the 1.11.4 release notes I realized that the new
>  > krb5_use_fast IPA default was not reflected in the man page. This patch
>  > fixes this omission.
>  
>  Ack, to this patch.
>  
>  Although maybe we should change in future and instead not the different
>  defaults in the respective sssd-ipa and sssd-ad mnapages ? 
I actually think your suggestion is better as that's what we use with
other options most of the time.

[Jakub Hrozek]

On Mon, Feb 17, 2014 at 06:19:03PM +0100, Jakub Hrozek wrote:
>  On Mon, Feb 17, 2014 at 11:59:29AM -0500, Simo Sorce wrote:
>  > On Mon, 2014-02-17 at 17:35 +0100, Jakub Hrozek wrote:
>  > > Hi,
>  > > 
>  > > while crafting the 1.11.4 release notes I realized that the new
>  > > krb5_use_fast IPA default was not reflected in the man page. This patch
>  > > fixes this omission.
>  > 
>  > Ack, to this patch.
>  > 
>  > Although maybe we should change in future and instead not the different
>  > defaults in the respective sssd-ipa and sssd-ad mnapages ?
>  
>  I actually think your suggestion is better as that's what we use with
>  other options most of the time. 
Attached is a patch that copies the option to the sssd-ipa man page
directly with the right defaults. I also removed the note that a keytab
is requires (since all IPA clients have keytabs) and fixed one minor
typo in the sssd-krb5 man page that I found by accident.

Thanks for the review.

[Simo Sorce]

On Mon, 2014-02-17 at 18:30 +0100, Jakub Hrozek wrote:
>  -                            Default: false (AD provide: true)
>  +                            Default: false (AD provider: true)  
I'm confused, why not adding the option to the AD provider as well ?
I think we should be consistent here, either list "AD and IPA" providers
both or neither ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Jakub Hrozek]

On Mon, Feb 17, 2014 at 12:58:33PM -0500, Simo Sorce wrote:
>  On Mon, 2014-02-17 at 18:30 +0100, Jakub Hrozek wrote:
>  > -                            Default: false (AD provide: true)
>  > +                            Default: false (AD provider: true) 
>  
>  I'm confused, why not adding the option to the AD provider as well ?
>  I think we should be consistent here, either list "AD and IPA" providers
>  both or neither ? 
This typo was in description of a different option
(krb5_use_enterprise_principal) which is present in both sssd-ad and
sssd-krb5 man pages. Just the default in sssd-krb5 described the values
for both ad and krb5.

Sorry, perhaps I should have sent a separate patch :)

[Simo Sorce]

On Mon, 2014-02-17 at 18:30 +0100, Jakub Hrozek wrote:
>  On Mon, Feb 17, 2014 at 06:19:03PM +0100, Jakub Hrozek wrote:
>  > On Mon, Feb 17, 2014 at 11:59:29AM -0500, Simo Sorce wrote:
>  > > On Mon, 2014-02-17 at 17:35 +0100, Jakub Hrozek wrote:
>  > > > Hi,
>  > > > 
>  > > > while crafting the 1.11.4 release notes I realized that the new
>  > > > krb5_use_fast IPA default was not reflected in the man page. This patch
>  > > > fixes this omission.
>  > > 
>  > > Ack, to this patch.
>  > > 
>  > > Although maybe we should change in future and instead not the different
>  > > defaults in the respective sssd-ipa and sssd-ad mnapages ?
>  > 
>  > I actually think your suggestion is better as that's what we use with
>  > other options most of the time.
>  
>  Attached is a patch that copies the option to the sssd-ipa man page
>  directly with the right defaults. I also removed the note that a keytab
>  is requires (since all IPA clients have keytabs) and fixed one minor
>  typo in the sssd-krb5 man page that I found by accident.
>  
>  Thanks for the review. 
ACK

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

[Jakub Hrozek]

On Mon, Feb 17, 2014 at 01:27:00PM -0500, Simo Sorce wrote:
>  On Mon, 2014-02-17 at 18:30 +0100, Jakub Hrozek wrote:
>  > On Mon, Feb 17, 2014 at 06:19:03PM +0100, Jakub Hrozek wrote:
>  > > On Mon, Feb 17, 2014 at 11:59:29AM -0500, Simo Sorce wrote:
>  > > > On Mon, 2014-02-17 at 17:35 +0100, Jakub Hrozek wrote:
>  > > > > Hi,
>  > > > > 
>  > > > > while crafting the 1.11.4 release notes I realized that the new
>  > > > > krb5_use_fast IPA default was not reflected in the man page. This
> patch
>  > > > > fixes this omission.
>  > > > 
>  > > > Ack, to this patch.
>  > > > 
>  > > > Although maybe we should change in future and instead not the different
>  > > > defaults in the respective sssd-ipa and sssd-ad mnapages ?
>  > > 
>  > > I actually think your suggestion is better as that's what we use with
>  > > other options most of the time.
>  > 
>  > Attached is a patch that copies the option to the sssd-ipa man page
>  > directly with the right defaults. I also removed the note that a keytab
>  > is requires (since all IPA clients have keytabs) and fixed one minor
>  > typo in the sssd-krb5 man page that I found by accident.
>  > 
>  > Thanks for the review.
>  
>  ACK
>  
>  Simo. 
Pushed to master and sssd-1-11