ehlo,
new version introduced checking format string and thus it is not possible to use fail_if/fail_unless without msg parameter.
PTAL
LS
On Tue, Jul 28, 2020 at 12:29 PM Pavel Březina pbrezina@redhat.com wrote:
On 7/25/20 8:45 PM, Lukas Slebodnik wrote:
ehlo,
new version introduced checking format string and thus it is not possible to use fail_if/fail_unless without msg parameter.
PTAL
LS
Thank you. Pushed.
Seems this introduced new warnings on rawhide: ``` ../src/tests/debug-tests.c: In function ‘test_debug_convert_old_level_old_format_fn’: ../src/tests/debug-tests.c:59:21: warning: too many arguments for format [-Wformat-extra-args] 59 | "Invalid conversion of %d", old_level); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/tests/debug-tests.c: In function ‘test_debug_convert_old_level_new_format_fn’: ../src/tests/debug-tests.c:68:9: warning: too many arguments for format [-Wformat-extra-args] 68 | "Invalid conversion of SSSDBG_UNRESOLVED" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/tests/debug-tests.c:72:9: warning: too many arguments for format [-Wformat-extra-args] 72 | "Invalid conversion of SSSDBG_FATAL_FAILURE" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` etc
On 8/18/20 11:42 AM, Alexey Tikhonov wrote:
On Tue, Jul 28, 2020 at 12:29 PM Pavel Březina <pbrezina@redhat.com mailto:pbrezina@redhat.com> wrote:
On 7/25/20 8:45 PM, Lukas Slebodnik wrote: > ehlo, > > new version introduced checking format string and thus it is not possible > to use fail_if/fail_unless without msg parameter. > > PTAL > > LS Thank you. Pushed.
Seems this introduced new warnings on rawhide:
../src/tests/debug-tests.c: In function ‘test_debug_convert_old_level_old_format_fn’: ../src/tests/debug-tests.c:59:21: warning: too many arguments for format [-Wformat-extra-args] 59 | "Invalid conversion of %d", old_level); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/tests/debug-tests.c: In function ‘test_debug_convert_old_level_new_format_fn’: ../src/tests/debug-tests.c:68:9: warning: too many arguments for format [-Wformat-extra-args] 68 | "Invalid conversion of SSSDBG_UNRESOLVED" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/tests/debug-tests.c:72:9: warning: too many arguments for format [-Wformat-extra-args] 72 | "Invalid conversion of SSSDBG_FATAL_FAILURE" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
etc
That's because they keep changing the API, trying to make it backwards compatible but always breaks something else. We need to wait until [1] is closed and it becomes stable again.
sssd-devel@lists.fedorahosted.org