jhrozek commented on a pull request
""" On Thu, Sep 01, 2016 at 09:01:54AM -0700, lslebodn wrote:
On (01/09/16 08:35), fidencio wrote:
On Thu, Sep 1, 2016 at 2:10 PM, lslebodn notifications@github.com wrote:
On (01/09/16 04:32), Jakub Hrozek wrote:
On Thu, Sep 01, 2016 at 03:21:06AM -0700, fidencio wrote:
On Thu, Sep 1, 2016 at 11:54 AM, lslebodn notifications@github.com
wrote:
On (31/08/16 23:18), fidencio wrote: >libini 1.0.0 is part of ding-libs 0.3.0 and has been around since
>Even the old systems that we have to support already have a newer >version of the library. RHEL6, for instance, has ding-libs 0.4.0
which
>provides libinit 1.1.0. > >By removing this code we also can stop depending on libcollection. > >Signed-off-by: Fabiano FidĂȘncio fidencio@redhat.com >You can view, comment on, or merge this pull request online at: > > https://github.com/SSSD/sssd/pull/10 > >-- Commit Summary -- > > * UTIL: Remove support to libini older than 1.0.0 > >-- File Changes -- > > M configure.ac (1) > M contrib/ci/deps.sh (1) > M contrib/sssd.spec.in (1) > D src/external/libcollection.m4 (9) > M src/util/sss_ini.c (97) > >-- Patch Links -- > >https://github.com/SSSD/sssd/pull/10.patch >https://github.com/SSSD/sssd/pull/10.diff > OpenSUSE LEAP has just ding-libs 0.3.0.1 in official repositories. http://software.opensuse.org/package/ding-libs?search_term=ding-libs
Yep. OpenSUSE LEAP has 0.3.0.1, Debian Stable (Jessie) has 0.4.0, latest Ubuntu LTS has 0.5.0. And all of them would be able to build SSSD with my patch without any
issues.
Two questions:
- how long until the distributions with too old ding-libs go out of
support?
Hmm. Unfortunately I don't have an answer for you. What are the major distributions that we want to support? Debian, Ubuntu LTS, RHEL, SLES ...?
I would prefer if limited version of sssd (ldap + krb5 provider) could be compiled almost anywhere. (even old distributions) It is not only about major distributions.
- since we will be (likely) supporting sssd-1-13 for the lifetime
of RHEL-6, can we say that the old distributions just use sssd-1-13?
libini_config-1.0 does not provide any new functionality which is not in libini_config < 1.0
They have just a different API (and moreover libini_config-1.0 still provides old API) (at least from sssd POV)
There's no new functionality, true. But there's a quite good API simplification
I agree that API is better. But feature wise are the same. So if we wanted to drop support for libini_config < 1.0 then we could drop support for libini_config-1.0. It would simplify more things in sssd
However, OpenSUSE LEAP has just a libini_config-1.0
This PR has stalled somehow. Can we either move it forward or reject?
I admit I got a bit lost in the comments, which distributions would we break with this patch? Are any of them supported/will be supported in th near future?
"""
See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-244928774
sssd-devel@lists.fedorahosted.org