[PATCH] AUTOTOOLS: More robust detection of inotify.

[Lukas Slebodnik]

ehlo,

We checked only header file "sys/inotify" for detection whether inotify
works. Some platforms do not have built in inotify, but contain library,
which provides inotify-compatible interface.

This patch adds more robust detection of inotify in configuration time and
appends linker flags to Makefile if inotify is provided by library.

Two patches are attached. 1st is for master (1.10) and 2nd is for branch 1.9

LS

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/02/2013 01:21 PM, Lukas Slebodnik wrote:
> ehlo,
>
> We checked only header file "sys/inotify" for detection whether
> inotify works. Some platforms do not have built in inotify, but
> contain library, which provides inotify-compatible interface.
>
> This patch adds more robust detection of inotify in configuration
> time and appends linker flags to Makefile if inotify is provided by
> library.
>
> Two patches are attached. 1st is for master (1.10) and 2nd is for
> branch 1.9

Nack. This fails to pass 'autoreconf -if':

configure:21415: error: possibly undefined macro: SSS_AC_EXPAND_LIB_DIR
      If this token and others are legitimate, please use
m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlIl0AAACgkQeiVVYja6o6OeEACeJavn3a9wdjO0ZYAl7657kh4Y
> CNgAnA54tuHLbYa3IzSOVIvfFa2c9Bdl
> =+xxH
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue 03 Sep 2013 08:03:12 AM EDT, Stephen Gallagher wrote:
> ********* *BEGIN ENCRYPTED or SIGNED PART* *********
>
> On 09/02/2013 01:21 PM, Lukas Slebodnik wrote:
> > ehlo,
> >
> > We checked only header file "sys/inotify" for detection whether 
> > inotify works. Some platforms do not have built in inotify, but 
> > contain library, which provides inotify-compatible interface.
> >
> > This patch adds more robust detection of inotify in
> > configuration time and appends linker flags to Makefile if
> > inotify is provided by library.
> >
> > Two patches are attached. 1st is for master (1.10) and 2nd is
> > for branch 1.9
>
> Nack. This fails to pass 'autoreconf -if':
>
> configure:21415: error: possibly undefined macro:
> SSS_AC_EXPAND_LIB_DIR If this token and others are legitimate,
> please use m4_pattern_allow. See the Autoconf documentation. 
> autoreconf: /usr/bin/autoconf failed with exit status: 1

Sorry, please disregard this. I didn't realize this was meant to
follow "Improve portability of autoconf and automake". I'll review
those first.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlIl0K0ACgkQeiVVYja6o6P+kQCeIWpq8nT89QmmNe4lv8TuF85i
> Aw8An0ekflXGt+TsHHG/GZ4whkyGae9B
> =qMZO
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/03/2013 08:06 AM, Stephen Gallagher wrote:
> On Tue 03 Sep 2013 08:03:12 AM EDT, Stephen Gallagher wrote:
> > ********* *BEGIN ENCRYPTED or SIGNED PART* *********
> > On 09/02/2013 01:21 PM, Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > We checked only header file "sys/inotify" for detection whether
> > >  inotify works. Some platforms do not have built in inotify,
> > > but contain library, which provides inotify-compatible
> > > interface.
> > >
> > > This patch adds more robust detection of inotify in 
> > > configuration time and appends linker flags to Makefile if 
> > > inotify is provided by library.
> > >
> > > Two patches are attached. 1st is for master (1.10) and 2nd is 
> > > for branch 1.9
> > Nack. This fails to pass 'autoreconf -if':
> > configure:21415: error: possibly undefined macro: 
> > SSS_AC_EXPAND_LIB_DIR If this token and others are legitimate, 
> > please use m4_pattern_allow. See the Autoconf documentation. 
> > autoreconf: /usr/bin/autoconf failed with exit status: 1
>
> Sorry, please disregard this. I didn't realize this was meant to 
> follow "Improve portability of autoconf and automake". I'll review 
> those first.

Atop the other patches: Ack.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlIl2WoACgkQeiVVYja6o6P8TgCgnEWOP0ylblnAoh33W1pt5Cxe
> tmIAn0cs/e+BXGGwg1qoH7RNYZWG5qZC
> =BITt
> -----END PGP SIGNATURE-----

[Jakub Hrozek]

On Tue, Sep 03, 2013 at 08:43:22AM -0400, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 09/03/2013 08:06 AM, Stephen Gallagher wrote:
> > On Tue 03 Sep 2013 08:03:12 AM EDT, Stephen Gallagher wrote:
> > > ********* *BEGIN ENCRYPTED or SIGNED PART* *********
> > > On 09/02/2013 01:21 PM, Lukas Slebodnik wrote:
> > > > ehlo,
> > > >
> > > > We checked only header file "sys/inotify" for detection whether
> > > >  inotify works. Some platforms do not have built in inotify,
> > > > but contain library, which provides inotify-compatible
> > > > interface.
> > > >
> > > > This patch adds more robust detection of inotify in 
> > > > configuration time and appends linker flags to Makefile if 
> > > > inotify is provided by library.
> > > >
> > > > Two patches are attached. 1st is for master (1.10) and 2nd is 
> > > > for branch 1.9
> > > Nack. This fails to pass 'autoreconf -if':
> > > configure:21415: error: possibly undefined macro: 
> > > SSS_AC_EXPAND_LIB_DIR If this token and others are legitimate, 
> > > please use m4_pattern_allow. See the Autoconf documentation. 
> > > autoreconf: /usr/bin/autoconf failed with exit status: 1
> >
> > Sorry, please disregard this. I didn't realize this was meant to 
> > follow "Improve portability of autoconf and automake". I'll review 
> > those first.
>
> Atop the other patches: Ack.

Pushed the first patch to master and sssd-1-10 and the second one to
sssd-1-9