6:44 a.m.
Hi,
this patch is about removing redudant debug message from middle layer of
autofs responder.
The point is that called function confdb_get_int() has very nice messaging.
Please, look at how we call autofs_get_config, there is another debug
message at top level, but this is important because it says that error
is fatal.
Regards
--
Petr^4 Čech
6:58 a.m.
On (21/04/16 13:44), Petr Cech wrote:
Hi,
this patch is about removing redudant debug message from middle layer of
autofs responder.
The point is that called function confdb_get_int() has very nice messaging.
Please, look at how we call autofs_get_config, there is another debug message
at top level, but this is important because it says that error is fatal.
Regards
--
Petr^4 Čech
From 545464d563f4aa382b7e177a4fe2ea966ab72c5b Mon Sep 17 00:00:00
2001
From: Petr Cech <pcech(a)redhat.com>
Date: Thu, 21 Apr 2016 07:32:28 -0400
Subject: [PATCH] AUTOFS: Removing of redudant debug message
Debug message has been doubled.
At a low level, we have a very accurate debug messsage with description
of situation (in confdb_get_int()). At higher level we informe about
the fatal crash, if it happend.
---
src/responder/autofs/autofssrv.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/responder/autofs/autofssrv.c b/src/responder/autofs/autofssrv.c
index ff30167298e0028da3f14f4d63a4d129c9c70bf0..80762cbc16d0a8048125c7df04ef92c71bc31426
100644
--- a/src/responder/autofs/autofssrv.c
+++ b/src/responder/autofs/autofssrv.c
@@ -64,12 +64,6 @@ autofs_get_config(struct autofs_ctx *actx,
ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
&actx->neg_timeout);
- if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from configuration [%d]:
%s\n",
- CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
- return ret;
- }
-
return EOK;
After this change, we will return EOK in case of failure.
LS
7:06 a.m.
On 04/21/2016 01:58 PM, Lukas Slebodnik wrote:
On (21/04/16 13:44), Petr Cech wrote:
> >Hi,
> >
> >this patch is about removing redudant debug message from middle layer of
> >autofs responder.
> >
> >The point is that called function confdb_get_int() has very nice messaging.
> >
> >Please, look at how we call autofs_get_config, there is another debug message
> >at top level, but this is important because it says that error is fatal.
> >
> >Regards
> >
> >--
> >Petr^4 Čech
>From 545464d563f4aa382b7e177a4fe2ea966ab72c5b Mon Sep 17 00:00:00 2001
> >From: Petr Cech<pcech(a)redhat.com>
> >Date: Thu, 21 Apr 2016 07:32:28 -0400
> >Subject: [PATCH] AUTOFS: Removing of redudant debug message
> >
> >Debug message has been doubled.
> >
> >At a low level, we have a very accurate debug messsage with description
> >of situation (in confdb_get_int()). At higher level we informe about
> >the fatal crash, if it happend.
> >---
> >src/responder/autofs/autofssrv.c | 6 ------
> >1 file changed, 6 deletions(-)
> >
> >diff --git a/src/responder/autofs/autofssrv.c b/src/responder/autofs/autofssrv.c
> >index
ff30167298e0028da3f14f4d63a4d129c9c70bf0..80762cbc16d0a8048125c7df04ef92c71bc31426 100644
> >--- a/src/responder/autofs/autofssrv.c
> >+++ b/src/responder/autofs/autofssrv.c
> >@@ -64,12 +64,6 @@ autofs_get_config(struct autofs_ctx *actx,
> > ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
> > CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
> > &actx->neg_timeout);
> >- if (ret != EOK) {
> >- DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from configuration [%d]:
%s\n",
> >- CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
> >- return ret;
> >- }
> >-
> > return EOK;
After this change, we will return EOK in case of failure.
LS
Sorry, it is my fault. You are right, Lukas.
Thanks.
Fixed patch attached.
Regards
--
Petr^4 Čech
4:10 a.m.
On (21/04/16 14:06), Petr Cech wrote:
On 04/21/2016 01:58 PM, Lukas Slebodnik wrote:
> On (21/04/16 13:44), Petr Cech wrote:
> > >Hi,
> > >
> > >this patch is about removing redudant debug message from middle layer of
> > >autofs responder.
> > >
> > >The point is that called function confdb_get_int() has very nice messaging.
> > >
> > >Please, look at how we call autofs_get_config, there is another debug
message
> > >at top level, but this is important because it says that error is fatal.
> > >
> > >Regards
> > >
> > >--
> > >Petr^4 Čech
> > From 545464d563f4aa382b7e177a4fe2ea966ab72c5b Mon Sep 17 00:00:00 2001
> > >From: Petr Cech<pcech(a)redhat.com>
> > >Date: Thu, 21 Apr 2016 07:32:28 -0400
> > >Subject: [PATCH] AUTOFS: Removing of redudant debug message
> > >
> > >Debug message has been doubled.
> > >
> > >At a low level, we have a very accurate debug messsage with description
> > >of situation (in confdb_get_int()). At higher level we informe about
> > >the fatal crash, if it happend.
> > >---
> > >src/responder/autofs/autofssrv.c | 6 ------
> > >1 file changed, 6 deletions(-)
> > >
> > >diff --git a/src/responder/autofs/autofssrv.c
b/src/responder/autofs/autofssrv.c
> > >index
ff30167298e0028da3f14f4d63a4d129c9c70bf0..80762cbc16d0a8048125c7df04ef92c71bc31426 100644
> > >--- a/src/responder/autofs/autofssrv.c
> > >+++ b/src/responder/autofs/autofssrv.c
> > >@@ -64,12 +64,6 @@ autofs_get_config(struct autofs_ctx *actx,
> > > ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
> > > CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
> > > &actx->neg_timeout);
> > >- if (ret != EOK) {
> > >- DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from configuration
[%d]: %s\n",
> > >- CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
> > >- return ret;
> > >- }
> > >-
> > > return EOK;
> After this change, we will return EOK in case of failure.
>
> LS
Sorry, it is my fault. You are right, Lukas.
Thanks.
Fixed patch attached.
Regards
--
Petr^4 Čech
From fd3fce416706a8a464ce8f56e466dce576e1cdca Mon Sep 17 00:00:00
2001
From: Petr Cech <pcech(a)redhat.com>
Date: Thu, 21 Apr 2016 07:32:28 -0400
Subject: [PATCH] AUTOFS: Removing of redudant debug message
Debug message has been doubled.
At a low level, we have a very accurate debug messsage with description
of situation (in confdb_get_int()). At higher level we informe about
the fatal crash, if it happend.
---
src/responder/autofs/autofssrv.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/responder/autofs/autofssrv.c b/src/responder/autofs/autofssrv.c
index ff30167298e0028da3f14f4d63a4d129c9c70bf0..eee7594ed1ca99f6f9549a49c3b88602f8b51795
100644
--- a/src/responder/autofs/autofssrv.c
+++ b/src/responder/autofs/autofssrv.c
@@ -64,13 +64,7 @@ autofs_get_config(struct autofs_ctx *actx,
ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
&actx->neg_timeout);
- if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from configuration [%d]:
%s\n",
- CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
- return ret;
- }
-
- return EOK;
+ return ret;
}
ACK
http://sssd-ci.duckdns.org/logs/job/42/81/summary.html
LS
4:11 a.m.
On (28/04/16 11:10), Lukas Slebodnik wrote:
On (21/04/16 14:06), Petr Cech wrote:
>On 04/21/2016 01:58 PM, Lukas Slebodnik wrote:
>> On (21/04/16 13:44), Petr Cech wrote:
>> > >Hi,
>> > >
>> > >this patch is about removing redudant debug message from middle layer
of
>> > >autofs responder.
>> > >
>> > >The point is that called function confdb_get_int() has very nice
messaging.
>> > >
>> > >Please, look at how we call autofs_get_config, there is another debug
message
>> > >at top level, but this is important because it says that error is
fatal.
>> > >
>> > >Regards
>> > >
>> > >--
>> > >Petr^4 Čech
>> > From 545464d563f4aa382b7e177a4fe2ea966ab72c5b Mon Sep 17 00:00:00 2001
>> > >From: Petr Cech<pcech(a)redhat.com>
>> > >Date: Thu, 21 Apr 2016 07:32:28 -0400
>> > >Subject: [PATCH] AUTOFS: Removing of redudant debug message
>> > >
>> > >Debug message has been doubled.
>> > >
>> > >At a low level, we have a very accurate debug messsage with description
>> > >of situation (in confdb_get_int()). At higher level we informe about
>> > >the fatal crash, if it happend.
>> > >---
>> > >src/responder/autofs/autofssrv.c | 6 ------
>> > >1 file changed, 6 deletions(-)
>> > >
>> > >diff --git a/src/responder/autofs/autofssrv.c
b/src/responder/autofs/autofssrv.c
>> > >index
ff30167298e0028da3f14f4d63a4d129c9c70bf0..80762cbc16d0a8048125c7df04ef92c71bc31426 100644
>> > >--- a/src/responder/autofs/autofssrv.c
>> > >+++ b/src/responder/autofs/autofssrv.c
>> > >@@ -64,12 +64,6 @@ autofs_get_config(struct autofs_ctx *actx,
>> > > ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
>> > > CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
>> > > &actx->neg_timeout);
>> > >- if (ret != EOK) {
>> > >- DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from
configuration [%d]: %s\n",
>> > >- CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
>> > >- return ret;
>> > >- }
>> > >-
>> > > return EOK;
>> After this change, we will return EOK in case of failure.
>>
>> LS
>
>Sorry, it is my fault. You are right, Lukas.
>Thanks.
>Fixed patch attached.
>
>Regards
>
>--
>Petr^4 Čech
>From fd3fce416706a8a464ce8f56e466dce576e1cdca Mon Sep 17 00:00:00 2001
>From: Petr Cech <pcech(a)redhat.com>
>Date: Thu, 21 Apr 2016 07:32:28 -0400
>Subject: [PATCH] AUTOFS: Removing of redudant debug message
>
>Debug message has been doubled.
>
>At a low level, we have a very accurate debug messsage with description
>of situation (in confdb_get_int()). At higher level we informe about
>the fatal crash, if it happend.
>---
> src/responder/autofs/autofssrv.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/src/responder/autofs/autofssrv.c b/src/responder/autofs/autofssrv.c
>index
ff30167298e0028da3f14f4d63a4d129c9c70bf0..eee7594ed1ca99f6f9549a49c3b88602f8b51795 100644
>--- a/src/responder/autofs/autofssrv.c
>+++ b/src/responder/autofs/autofssrv.c
>@@ -64,13 +64,7 @@ autofs_get_config(struct autofs_ctx *actx,
> ret = confdb_get_int(cdb, CONFDB_AUTOFS_CONF_ENTRY,
> CONFDB_AUTOFS_MAP_NEG_TIMEOUT, 15,
> &actx->neg_timeout);
>- if (ret != EOK) {
>- DEBUG(SSSDBG_OP_FAILURE, "Cannot read %s from configuration [%d]:
%s\n",
>- CONFDB_AUTOFS_MAP_NEG_TIMEOUT, ret, strerror(ret));
>- return ret;
>- }
>-
>- return EOK;
>+ return ret;
> }
ACK
http://sssd-ci.duckdns.org/logs/job/42/81/summary.html
master:
* c90fdc85cfb552911e29b4d284fd4c40ea1bb4e9
LS
2920
days inactive
2927
days old
sssd-devel@lists.fedorahosted.org
4 comments
2 participants
participants (2)
-
Lukas Slebodnik -
Petr Cech