[Bug 2505515] nss_sss: getpwnam results in a -1 fd being passed to fstat

https://bugzilla.redhat.com/show_bug.cgi?id=2505515

Tomas Halman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)
                   |                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #2 from Tomas Halman  ---
Hello Noah and Florian,

I have checked the code and the described behavior is expected.

We leverage the fact that fstat fails for us in such case. Code example:

ret = fstat(sss_cli_sd_get(), &mypid_sb);
        if (ret == 0) {
            if (S_ISSOCK(mypid_sb.st_mode) &&
                mypid_sb.st_dev == sss_cli_sb->st_dev &&
                mypid_sb.st_ino == sss_cli_sb->st_ino) {
                sss_cli_close_socket();
            }
        }
        sss_cli_sd_set(-1);

Does it actually causes any problems?