Apologies, the issue is we moved from using winbind via realmd which now seems to be
broken due to this:
https://bugzilla.samba.org/show_bug.cgi?id=14007 to using adcli, our
realmd.conf file had previously lower cased the computer-name like so:
computer-name = example
And samba apparently uppercased it on the join (EXAMPLE$). adcli appears not to do that
(example$). After some long research it looks like lower case is entirely legit for
NETBIOS names, but for whatever reason samba chooses to upper case the names.
So the change in behavior was unexpected, but is valid. However, getting net ads join to
work again in RHEL 7.7 is probably a good idea on Red Hat's part.
In short I expected adcli to act like net ads join, it doesn't, the former will accept
upper or lower case and probably anything in between, the latter upper cases the name.
Solution was to upper case the name with ADCLI so that it matches what we had previously.
Longer term solution is to be case insensitive when looking for a principle in the
keytab.
-Erinn