-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hello Christophe,
On Sun, 2016-08-21 at 22:15 +0200, Christophe Vu-Brugier wrote:
Dear Ritesh,
I am interested in having targetcli-fb in Debian and would like to help. I looked at your packages and I have a few remarks.
I am bothered by the packages being named "targetcli" and "python-configshell" because they come from the "free branch" (fb) fork. I would prefer them to be named "targetcli-fb" and "python-configshell-fb" respectively. I think it would clearly indicate where they come from.
So I suggest changing the name to "targetcli-fb" and "python-configshell-fb" and adding a "Conflicts: targetcli" and "Conflicts: python-configshell" in their "control" files.
My initial thought was to just switch the sources and leave the name alone. But I too think the cleaner approach will be to add them with the new name.
Once the -fb packages are clean and in shape, we can simply orphan the older ones and ask for their removal.
Moreover, you should adjust the "Homepage" tags in both packages: they currently point to Datera's GitHub repositories instead of the repositories of the open-iscsi organization.
In the "python-configshell-fb" package, you can drop the dependency to "python-epydoc" because it was made optional at runtime:
https://github.com/open-iscsi/configshell-fb/commit/672a80e253a67439168fef41 1804d9459ae086e0
Fantastic. This will cut out much of the bloat that gets pulled in.
Also in the "python-configshell-fb" package, you should replace the "python-simpleparse" dependency with "python-pyparsing".
Both packages should depend on "python-six" which is used to make their code compatible with Python 2 and Python 3.
Speaking of Python 3, you should probably provide packages for Python 3 as well and even make "targetcli-fb" available for Python 3 only.
If you are interested, I can work on patches to fix the issues I mentioned and send them to you.
Yes. Please do so. I'm open to the changes you've mentioned.
Just let me know where to pull from. We'll put a couple of package uploads in experimental first. Then we can setup an LIO target with those packages, test, and eventually push them to Unstable.
We still have time to have the -fb packages replace the Datera ones before the freeze. But the sooner we do, the better testing/feedback we may get.
With best regards,
Thank you for your interest and help.
Ritesh
- -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System