-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Dear Ritesh,
I am interested in having targetcli-fb in Debian and would like to help.
I looked at your packages and I have a few remarks.
I am bothered by the packages being named "targetcli" and
"python-configshell" because they come from the "free branch" (fb)
fork. I would prefer them to be named "targetcli-fb" and
"python-configshell-fb" respectively. I think it would clearly
indicate where they come from.
So I suggest changing the name to "targetcli-fb" and
"python-configshell-fb" and adding a "Conflicts: targetcli" and
"Conflicts: python-configshell" in their "control" files.
Moreover, you should adjust the "Homepage" tags in both packages: they
currently point to Datera's GitHub repositories instead of the
repositories of the open-iscsi organization.
In the "python-configshell-fb" package, you can drop the dependency to
"python-epydoc" because it was made optional at runtime:
https://github.com/open-iscsi/configshell-fb/commit/672a80e253a67439168fe...
Also in the "python-configshell-fb" package, you should replace the
"python-simpleparse" dependency with "python-pyparsing".
Both packages should depend on "python-six" which is used to make
their code compatible with Python 2 and Python 3.
Speaking of Python 3, you should probably provide packages for Python
3 as well and even make "targetcli-fb" available for Python 3 only.
If you are interested, I can work on patches to fix the issues I
mentioned and send them to you.
With best regards,
- --
Christophe Vu-Brugier
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJXugwAAAoJEAg5C33y/Bh2VK4QAJxYm7pc+ourGa0hhd3xSKeg
BUOzFouSOr9Mrwzg51Ttw8j+msUW80lkBj2+m+v19rRh4d6aHgIZbMhHH3b+I4CX
+nQeOXpl2Ez/AulQrzsmPDORY13sWMd9Ep+eOmJZ2f3WrOT8U+JuUqI/dQoVP2Ck
fUBetshlKmo8b7ASFFk4Qk6rVPebu725+rl8ZIIOBn1fS6calzAlTZlZAv/je6Rp
Pes8SRsXKTO+u5GDehRjv2LBZF29z2OsTAHE3qplO4sD3VtpN+gZmZs+xFUhqdrM
CvgzTSyVuVrp4MGm9GuHTjaKuzjE0qprzUx71rMAxyqnZa2W8enC9H5Sk2J6EN3q
8+lQQtgStIY1poKP7flY/ecj23/61Lj7m3HTXFYsQ3U4J/IrJ2FNKyJvA+r2mGgA
KTtr8r1MlxIUX0LMx2xuMWILR/l9ph5x9uMmYwY9KnSK8vv3lq63vTJ3vYIw1me4
HkW7DLWcNk+bxg/q/V6o3h7Irqih1ZFGphaW7l6tjH2DtnDmravLDGuzBnmnYKxa
TwNdMLcDhztgLd3rOiXs9qyf8PN+mWp5AI49oQrP0zUJf26WnWnCXjPWnaLDZS/p
XeHhwFEMwJ8ZTwaDohQOZ8QkdvfyR+71iZ/fKFbjw/LrfwP7KZM47d3ljer5+nqR
LGr+KBvsFE7VEXwNz6iQ
=VoKC
-----END PGP SIGNATURE-----