Re: ErrorRecoveryLevel Set as read-only Randomly.

[Andy Grover]

On 04/17/2014 01:42 PM, Nicholas A. Bellinger wrote:
>  Hi Arshad,
>
>  On Wed, 2014-04-09 at 14:51 +0530, Arshad Hussain wrote:
> > Hi Nab,
> >
> > Randomly my targetcli sets 'ErrorRecoveyLevel' as read only.
> > I have checked the configfs and debugfs they are both mounted
> > with permission of read and write. What surprises me is that
> > the ERL and default_erl under 'tpg1' is fine. It is only the
> > ERL parameter under 'acls/iqn...' which is marked read-only.
> >
> > Could you comment on this please ? Is there a work-around to
> > get over this issue?
> >
> > I have provided the details below. Please let me know if there any
> > other info you require?
> >
> > Thanks,
> > Arshad
> >
> > <snip>
> > /iscsi/iqn.20...t:981fc286f48> get parameter ErrorRecoveryLevel
> > ErrorRecoveryLevel=No Active iSCSI Session [ro]
> > /iscsi/iqn.20...t:981fc286f48> set parameter ErrorRecoveryLevel=2
> > Parameter ErrorRecoveryLevel is read-only.
> > /iscsi/iqn.20...t:981fc286f48>
> >
> > /iscsi/iqn.20...t:981fc286f48> get attribute default_erl
> > default_erl=2
> > /iscsi/iqn.20...t:981fc286f48>
> >
> > /iscsi/iqn.20...093081c0/tpg1> pwd
> > /iscsi/iqn.2003-01.org.linux-iscsi.wfs.x8664:sn.a6fd093081c0/tpg1
> > /iscsi/iqn.20...093081c0/tpg1> get parameter ErrorRecoveryLevel
> > ErrorRecoveryLevel=2
> > /iscsi/iqn.20...093081c0/tpg1> get attribute default_erl
> > default_erl=2
> > /iscsi/iqn.20...093081c0/tpg1> 
>  I'm not able to reproduce using upstream targetcli code, so I can
> only
>  assume it's some -fb specific breakage.  CC'ing Grover. 
[adding CC targetcli-fb-devel]

Is this really random? it looks to me like all params under the acl are ro.

from iscsi_target_configfs.c:601

#define NACL_PARAM_ATTR(_name) TF_NACL_PARAM_ATTR_RO(iscsi, _name);
                                                   ^^
...

DEF_NACL_PARAM(ErrorRecoveryLevel);

so yes it's read-only for the acl.

Is it just that you can set ERL in the tpg but not per-acl? And you only 
get the value (instead of "no active iscsi session") when there is a 
session. Is that the problem or something else?

Regards -- Andy

ErrorRecoveryLevel Set as read-only Randomly.

[Nicholas A. Bellinger]

On Thu, 2014-04-17 at 15:29 -0700, Andy Grover wrote:
>  On 04/17/2014 01:42 PM, Nicholas A. Bellinger wrote:
>  > Hi Arshad,
>  >
>  > On Wed, 2014-04-09 at 14:51 +0530, Arshad Hussain wrote:
>  >> Hi Nab,
>  >>
>  >> Randomly my targetcli sets 'ErrorRecoveyLevel' as read only.
>  >> I have checked the configfs and debugfs they are both mounted
>  >> with permission of read and write. What surprises me is that
>  >> the ERL and default_erl under 'tpg1' is fine. It is only the
>  >> ERL parameter under 'acls/iqn...' which is marked read-only.
>  >>
>  >> Could you comment on this please ? Is there a work-around to
>  >> get over this issue?
>  >>
>  >> I have provided the details below. Please let me know if there any
>  >> other info you require?
>  >>
>  >> Thanks,
>  >> Arshad
>  >>
>  >> <snip>
>  >> /iscsi/iqn.20...t:981fc286f48> get parameter ErrorRecoveryLevel
>  >> ErrorRecoveryLevel=No Active iSCSI Session [ro]
>  >> /iscsi/iqn.20...t:981fc286f48> set parameter ErrorRecoveryLevel=2
>  >> Parameter ErrorRecoveryLevel is read-only.
>  >> /iscsi/iqn.20...t:981fc286f48>
>  >>
>  >> /iscsi/iqn.20...t:981fc286f48> get attribute default_erl
>  >> default_erl=2
>  >> /iscsi/iqn.20...t:981fc286f48>
>  >>
>  >> /iscsi/iqn.20...093081c0/tpg1> pwd
>  >> /iscsi/iqn.2003-01.org.linux-iscsi.wfs.x8664:sn.a6fd093081c0/tpg1
>  >> /iscsi/iqn.20...093081c0/tpg1> get parameter ErrorRecoveryLevel
>  >> ErrorRecoveryLevel=2
>  >> /iscsi/iqn.20...093081c0/tpg1> get attribute default_erl
>  >> default_erl=2
>  >> /iscsi/iqn.20...093081c0/tpg1>
>  
>  > I'm not able to reproduce using upstream targetcli code, so I can only
>  > assume it's some -fb specific breakage.  CC'ing Grover.
>  
>  [adding CC targetcli-fb-devel]
>  
>  Is this really random? it looks to me like all params under the acl are ro.
>  
>  from iscsi_target_configfs.c:601
>  
>  #define NACL_PARAM_ATTR(_name) TF_NACL_PARAM_ATTR_RO(iscsi, _name);
>                                                     ^^
>  ...
>  
>  DEF_NACL_PARAM(ErrorRecoveryLevel);
>  
>  so yes it's read-only for the acl.
>  
>  Is it just that you can set ERL in the tpg but not per-acl? And you only 
>  get the value (instead of "no active iscsi session") when there is a 
>  session. Is that the problem or something else?
>   
This is correct.  Only the TPG parameter values can be changed, which
are then propagated down to individual NodeACL parameters as sessions
are created that reference specific InitiatorName entities.

So yeah, there is nothing random about it.  ;)

--nab

ErrorRecoveryLevel Set as read-only Randomly.

[Arshad Hussain]

Hi Nab, Andy
On 4/18/2014 4:16 AM, Nicholas A. Bellinger wrote:
>  On Thu, 2014-04-17 at 15:29 -0700, Andy Grover wrote:
> > <SNIP
> >  
> >> I'm not able to
> reproduce using upstream targetcli code, so I can only
> >> assume it's some -fb specific breakage.  CC'ing Grover.
> > [adding CC targetcli-fb-devel]
> >  
> > Is this really random? it looks to me like all params
> under the acl are ro.
> >  
> > from iscsi_target_configfs.c:601
> >  
> > #define NACL_PARAM_ATTR(_name)
> TF_NACL_PARAM_ATTR_RO(iscsi, _name);
> >                                                    ^^
> > ...
> >  
> > DEF_NACL_PARAM(ErrorRecoveryLevel);
> >  
> > so yes it's read-only for the acl.
> >  
> > Is it just that you can set ERL in the tpg but not
> per-acl? And you only 
> > get the value (instead of "no active iscsi session") when there is a 
> > session. Is that the problem or something else? 
Thanks for the explanation. Now
this is clear.
>  This is correct.  Only the TPG parameter values can be changed,
> which
>  are then propagated down to individual NodeACL parameters as sessions
>  are created that reference specific InitiatorName entities.
>
>  So yeah, there is nothing random about it.  ;)
>
>  --nab 
Thanks for the explanation. Understood.
>  
Thanks,
Arshad