On Mon, Aug 10, 2020 at 8:56 PM Adam Williamson <adamwill@fedoraproject.org> wrote:

As mentioned in the IRC meeting today, I have a small nit with this:
the criterion as it exists right now is conceptually intended as a
"Stopping The Session" criterion. It covers three things which are all,
broadly, ways to stop the current session. If we stick "logging in"
into it in this way, we lose that conceptual clarity and it potentially
makes the overall...idea...of the criterion more muddy and hard to
read.

Just a note here - once you said it, the intention of the criterion became clear to me. But originally I did not have a slightest idea that there's a common theme behind those 3 actions defined in there. So while the intention is there, it's very subtle, and I think there will be very few people for whom the change would make it harder to read.

On the whole I feel like considering all requirements related to log
in, log out, shutdown, restart, and user switch together we should be
able to come up with a better option either than a standalone new
criterion (Geoff's proposal) or this add-on to the "end session"
criterion (Kamil's proposal), but I think either proposal would be
*okay* if we don't get the time to come up with something better. Just
wanted to flag that up for discussion.

I'd accept the criterion as proposed (because we need it now), and do the reorganization later (possibly when this cycle is over and we have more time to bikeshed about best criterion layout). I'm fine with either adding to the existing criterion (mine version) or creating a standalone criterion (Geoff's version), just note that the standalone version would still need to get tweaked (remove "multiple user accounts", etc).