On Wed, 2018-05-30 at 16:31 +0200, Lukas Ruzicka wrote:
So this is another kind of tricksy one unfortunately :/
The requirement is really supposed to be that the spin-kickstarts
package exactly matches the kickstarts used for the compose. So I
actually test this by installing the packages and then running a
recursive diff of the package content against the content of a git
checkout of the fedora-kickstarts repo on the appropriate branch.
It's also worth noting that kickstarts change a lot during development
so we really don't keep this package up to date throughout the cycle,
we only go ahead and send out a 'synced' package very late during Final
freeze.
Honestly, I'm kinda more inclined to propose we nix this requirement
than we write a test case for it. It's kind of a quixotic requirement
now, to be honest. The motivation behind it is to make the compose
repeatable - the idea being that if you have a full set of Fedora 28
packages, you can reproduce the release images perfectly - but having a
'correct' kickstarts package alone really doesn't ensure this, and we
don't really require any of the other things that would actually ensure
it. I just don't see a great benefit to the package or the criterion
any more, to be honest. I think we should talk to rel-eng about whether
they'd agree with the idea of dropping the criterion and perhaps having
a policy of creating a tag in the git repo whenever a compose is run
(the tag would match the compose ID) instead, or something like that.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net