Unable to upload POT file to any libvirt project component

[Daniel P. Berrangé]

When we first setup the libvirt-glib project, I was able to use

 $ wlc upload --method replace -i libvirt-glib.pot libvirt-glib/master/en

to upload the .pot file into the "en.po" file on the server, which
was marked as the base language for translation.

Since then, the libvirt-glib project was renamed, and libvirt &
libvirt-sandbox were added as further components.

Now when I try to upload the .pot, weblate is not accepting any of
the strings.

At first I thought I was still hitting the upload size limit, but
debugging I see this is not the case.

  $ wlc upload --method replace -i libvirt-glib.pot libvirt-glib/master/en
  Error: Failed to upload translations!

Despite failing, it *has* made some change in the git repository,
because I now see this new commit:

commit 56edd0b79dd3f4c296626afabaed67d04d56c1ed
Author: Daniel P. Berrange <berrange(a)redhat.com&gt;
Date:   Mon Jan 13 21:20:53 2020 +0000

    Translated using Weblate (English)
    
    Currently translated at 0.0% (0 of 31 strings)
    
    Translation: libvirt/libvirt-glib
    Translate-URL:
https://translate.stg.fedoraproject.org/projects/libvirt/libvirt-glib/en/

diff --git a/en.po b/en.po
index a4e737c..750982c 100644
--- a/en.po
+++ b/en.po
@@ -1,9 +1,7 @@
 # Libvirt package strings.
 # Copyright (C) 2019 The Libvirt authors
 # This file is distributed under the same license as the libvirt-glib package.
-# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
-#
-#, fuzzy
+# Daniel P. Berrange <berrange(a)redhat.com&gt;, 2020.
 msgid ""
 msgstr ""
 "Project-Id-Version: libvirt-glib 3.0.0\n"
@@ -12,7 +10,7 @@ msgstr ""
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL(a)li.org&gt;\n&quot;
-"Language: \n"
+"Language: en\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"


In addition the weblate UI is reporting errors for libvirt-glib now

[quote]
Duplicated translation

The component contains several translation files mapped to single language in Weblate.

The following occurrences were found:
Language	Language codes
English	en, en

Please fix this by removing one of the duplicated strings from the translation files.
[/quote]

The same has happened to the git repos for libvirt and libvirt-sandbox
too.

The error goes away if I put the project back to "gettext (monlingual)"
but I'm still unable to upload the pot file to en.po again.

I'm thinking about what has changed since I was first succesfully able
to upload:

 - The project now has three separate components each with their
   own git repo
 - The "Automatic translation" and "Language consistency" addons
   have been installed

My guess is that possibly the language consistency addon has
caused the problem. I think perhaps it has tried to synchronize
the "en.po" file across the three repos and this confused things,
now preventing me treating it as the string base file.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Jean-Baptiste Holcroft]

Hello Daniel

It's a long list of requests, thanks for sharing all this.

First of all: what you did was to create a smart hack to bypass the fact 
Weblate don't allow pot push.
This probably is the root cause of your issues.

Would you mind considering one of these options?
* create a shared repository for your translation, the same way I 
created this one for fedora websites: 
https://pagure.io/fedora-web/translations/tree/master and plug weblate 
on it.
   you'll see automation done by me there: 
https://pagure.io/fedora-websites/pull-request/1015#request_diff

* create a dedicated repository for each of your projects 
https://github.com/cockpit-project/cockpit-weblate
   you'll see automation done by Cockpit team there: 
https://github.com/cockpit-project/cockpit/commit/9cc6b230e4748a676e4bffa...

* wait for this upstream issue to be fixed 
https://github.com/WeblateOrg/weblate/issues/3349 (or implement it, or 
pay for it) and use Zanata until there.

Jean-Baptiste

[Daniel P. Berrangé]

On Wed, Jan 15, 2020 at 03:18:09PM +0100, Jean-Baptiste Holcroft wrote:
>  Hello Daniel
>  
>  It's a long list of requests, thanks for sharing all this.
>  
>  First of all: what you did was to create a smart hack to bypass the fact
>  Weblate don't allow pot push.
>  This probably is the root cause of your issues.
>  
>  Would you mind considering one of these options?
>  * create a shared repository for your translation, the same way I created
>  this one for fedora websites:
>  https://pagure.io/fedora-web/translations/tree/master and plug weblate on
>  it.
>    you'll see automation done by me there:
>  https://pagure.io/fedora-websites/pull-request/1015#request_diff 
This could be viable since it avoids creating multiple side repos.

If we use gitlab for this, is it possible to get weblate to push
directly, instead of opening merge requests ?

I'm thinking I can do some automation where any change pushed to
the translation repo by weblate, it triggers a CI job to minimize
the .po file and then open a merge request to libvirt itself.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[Jean-Baptiste Holcroft]

Le 2020-01-16 13:09, Daniel P. Berrangé a écrit :
>  If we use gitlab for this, is it possible to get weblate to push
>  directly, instead of opening merge requests ? 
Yes, I think you'll just have to allow this user to write in your 
repository: https://gitlab.com/weblate
Thank you for adopting this solution :)

As we are back from support to configuration, let's continue on Bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1783579

Jean-Baptiste