Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: gcore produces incorrect elf_prpsinfo note data
https://bugzilla.redhat.com/show_bug.cgi?id=254229
------- Additional Comments From jan.kratochvil(a)redhat.com 2008-07-29 08:14 EST -------
(In reply to comment #14)
> Fixed one 80 column rule violation, don't know what to do with this one:
http://www.gnu.org/prep/standards/standards.html
does not talk about 80 columns at all.
I hope it is just really a detail how to format it.
`indent -gnu' will do:
char *(*linux_elfcore_write_prpsinfo)
(bfd *, char *, int *, void *, const char *, const char *) =
elfcore_write_prpsinfo;
but it will leave the other forms without reformatting.
I would find better to follow the existing style around in the code there:
char *(*linux_elfcore_write_prpsinfo)
(bfd *, char *, int *, void *, const char *, const char *)
= elfcore_write_prpsinfo;
and while writing it as GNU compliant new I would probably choose:
char *(*linux_elfcore_write_prpsinfo) (bfd *, char *, int *, void *,
const char *, const char *)
= elfcore_write_prpsinfo;
but I hope it should not matter much (as long as it is <=80) to have better
chance of an upstream acceptance (not that I would be too much successful).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: gcore produces incorrect elf_prpsinfo note data
https://bugzilla.redhat.com/show_bug.cgi?id=254229
dvlasenk(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #312860|0 |1
is obsolete| |
------- Additional Comments From dvlasenk(a)redhat.com 2008-07-29 07:59 EST -------
Created an attachment (id=312861)
--> (https://bugzilla.redhat.com/attachment.cgi?id=312861&action=view)
Updated patch according to Jan's comments, v2
Fixed one 80 column rule violation, don't know what to do with this one:
char *(*linux_elfcore_write_prpsinfo)
- (bfd *, char *, int *, const char *, const char *) = elfcore_write_prpsinfo;
+ (bfd *, char *, int *, void *, const char *, const char *) =
elfcore_write_prpsinfo;
Should it be wrapped, or would it impact readability too much.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: gcore produces incorrect elf_prpsinfo note data
https://bugzilla.redhat.com/show_bug.cgi?id=254229
dvlasenk(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #312823|0 |1
is obsolete| |
------- Additional Comments From dvlasenk(a)redhat.com 2008-07-29 07:41 EST -------
Created an attachment (id=312860)
--> (https://bugzilla.redhat.com/attachment.cgi?id=312860&action=view)
Updated patch according to Jan's comments.
Jan, I believe I addressed all your concerns in this patch. Let me know if you
see something in need of further work.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Kscreensaver fails to unlock
https://bugzilla.redhat.com/show_bug.cgi?id=196151
------- Additional Comments From mefoster(a)gmail.com 2008-07-29 04:07 EST -------
Happened again on the most recent Fedora 9 KDE update. Is there some reason not
to add the chmod u+s to the kdebase-workspace rpm?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Left-handed mouse orientation also changes touchpad touch click
https://bugzilla.redhat.com/show_bug.cgi?id=324721
------- Additional Comments From peter.hutterer(a)redhat.com 2008-07-28 21:13 EST -------
SetDeviceButtonMapping is definitely the right way to go. In theory, a touchpad
should have the Atom XI_TOUCHPAD set as its type, although at least synaptics
doesn't do it.
so you need some other (human) method to figure out which device is a touchpad.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Left-handed mouse orientation also changes touchpad touch click
https://bugzilla.redhat.com/show_bug.cgi?id=324721
mcepl(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |peter.hutterer(a)redhat.com
------- Additional Comments From mcepl(a)redhat.com 2008-07-28 18:24 EST -------
(In reply to comment #6)
> We don't need a configuration tool, we need to detect that the touch pad and
> not remap it (assuming that's possible)
Peter, what do you think?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: gcore produces incorrect elf_prpsinfo note data
https://bugzilla.redhat.com/show_bug.cgi?id=254229
jan.kratochvil(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #312653|0 |1
is obsolete| |
------- Additional Comments From jan.kratochvil(a)redhat.com 2008-07-28 17:31 EST -------
Created an attachment (id=312823)
--> (https://bugzilla.redhat.com/attachment.cgi?id=312823&action=view)
Rawhide (=Fedora 9) patch, v3.
Did some update I would like there.
Unfortunately I have some problems with RHTS (partially with YUM) now so it
still has not been verifified as regression-free.
Always use xfree(), not free().
GNU indentation: func() -> func ().
Always use NULL-protected allocations: xmalloc/xzalloc/...
Empty line between declarations and code.
/* Two spaces after each sentence dot. Like here. */
`return val;' (with any cleanups) is preceded by an empty line.
(Not fixed.) GDB and I believe all the GNU programs limit the line length to 80
characters; some GDB code violates it, though.
Write complete sentences in the comments.
(Not fixed.) `#if ...\n#define ...'should be indented `#if ...\n# define ...'.
Function parameters should be aligned behind '(' (at `sscanf').
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: can't commit pre-edit state by clicking in kedit
https://bugzilla.redhat.com/show_bug.cgi?id=220414
smparrish(a)shallowcreek.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |CLOSED
Resolution| |WONTFIX
Flag|needinfo?(than(a)redhat.com) |
------- Additional Comments From smparrish(a)shallowcreek.net 2008-07-28 16:46 EST -------
Going to close this, if you feel there is still an issue please feel free to
reopen and add additional comments.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: analyzer draws on top of buttons
https://bugzilla.redhat.com/show_bug.cgi?id=250746
smparrish(a)shallowcreek.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |CLOSED
Resolution| |INSUFFICIENT_DATA
Flag|needinfo?(bdwheele(a)indiana.e|
|du) |
------- Additional Comments From smparrish(a)shallowcreek.net 2008-07-28 16:22 EST -------
The information we've requested above is required in order
to review this problem report further and diagnose or fix the
issue if it is still present. Since it has been thirty days or
more since we first requested additional information, we're assuming
the problem is either no longer present in the current Fedora release, or
that there is no longer any interest in tracking the problem.
Setting status to "CLOSED INSUFFICIENT_DATA". If you still
experience this problem after updating to our latest Fedora
release and can provide the information previously requested,
please feel free to reopen the bug report.
Thank you in advance.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Left-handed mouse orientation also changes touchpad touch click
https://bugzilla.redhat.com/show_bug.cgi?id=324721
rstrode(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|control-center- |bnocera(a)redhat.com
|maint(a)redhat.com |
Component|control-center |gnome-settings-daemon
------- Additional Comments From rstrode(a)redhat.com 2008-07-28 15:38 EST -------
So at one point a long time ago gnome-settings-daemon just SetPointerMapping and
when users set their mouse to left handed mode only the first mouse would be
left handed and subsequent mice would be right handed.
(It got even weirder if you had /dev/mice as one device and /dev/input/mouse2
then you'd end up with the left and right mouse button getting pressed
simultaneously no matter which button you pressed)
I fixed that in gnome-settings-daemon by using SetDeviceButtonMapping on every
mouse device to be left handed. I assume the code is still like that, but I
haven't looked at it in a while.
We don't need a configuration tool, we need to detect that the touch pad and not
remap it (assuming that's possible)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.