[PATCH] procview: fix thread refresh when using polling mode

[Federico Pellegrin]

When in polling mode the GUI seems not to be refreshing new threads
that are added to a process. If the GUI is totally redrawn (ie.
stop and start refreshing) then it will be displayed, so the
problem comes out just when an already drawn process gets new
threads.
This is fixed by making sure that for both new and already existing
processes the threads information is refreshed.
This bug was introduced with tabs->space transition.

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/gui/procview.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
index c5b5f1f..c224e4b 100755
--- a/tuna/gui/procview.py
+++ b/tuna/gui/procview.py
@@ -467,8 +467,8 @@ class procview:
                         children = threads[tid]["threads"]
                     else:
                         children = {}
-                        child_row = self.tree_store.iter_children(row)
-                        self.update_rows(children, child_row, row)
+                    child_row = self.tree_store.iter_children(row)
+                    self.update_rows(children, child_row, row)
                 except: # thread doesn't exists anymore
                     if self.tree_store.remove(row):
                         # removed and now row is the next one
-- 
2.26.3

[John Kacur]

On Mon, 22 Mar 2021, Federico Pellegrin wrote:

>  When in polling mode the GUI seems not to be refreshing new threads
>  that are added to a process. If the GUI is totally redrawn (ie.
>  stop and start refreshing) then it will be displayed, so the
>  problem comes out just when an already drawn process gets new
>  threads.
>  This is fixed by making sure that for both new and already existing
>  processes the threads information is refreshed.
>  This bug was introduced with tabs->space transition.
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/procview.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>  
>  diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
>  index c5b5f1f..c224e4b 100755
>  --- a/tuna/gui/procview.py
>  +++ b/tuna/gui/procview.py
>  @@ -467,8 +467,8 @@ class procview:
>                           children = threads[tid]["threads"]
>                       else:
>                           children = {}
>  -                        child_row = self.tree_store.iter_children(row)
>  -                        self.update_rows(children, child_row, row)
>  +                    child_row = self.tree_store.iter_children(row)
>  +                    self.update_rows(children, child_row, row)
>                   except: # thread doesn't exists anymore
>                       if self.tree_store.remove(row):
>                           # removed and now row is the next one
>  -- 
>  2.26.3 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;