sieve scripts

[Tim]

Hi,

I've just gotten around to using sieve with Dovecot, and trying to work
out how scripts should be written has been a bit of a headache.  There
doesn't seem to be coherent documentation, just various people's
cobbled together notes.  So I'm wondering if anybody can see anything
glaringly wrong, or missing, that I haven't noticed in this script.  It
seems to be working, but I don't know if that's by accident, or I've
done it right.

require ["fileinto"];

##### mail test 1 #####
#if header :contains "subject" "mailtest"
#{
#  fileinto "tests";
#  stop;
#}

##### Fedora list #####
if header :contains "List-Id" "users.lists.fedoraproject.org"
{
  fileinto "lists.Fedora 2021";
  stop;
}

###### Fedora 32 updates #####
if allof
(
  header :contains "List-Id" "package-announce.lists.fedoraproject.org",
  header :contains "subject" "Fedora 32 update"
)
{
  fileinto "announcements.Fedora 32";
  stop;
}

##### Fedora 33 updates #####
if allof
(
  header :contains "List-Id" "package-announce.lists.fedoraproject.org",
  header :contains "subject" "Fedora 33 update"
)
{
  fileinto "announcements.Fedora 33";
  stop;
}